feat: add new registration-service config param for ui canary deployement #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancisc
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
rsoaresd,
fbm3307,
metlos and
jrosental
as code owners
alexeykazakov
approved these changes
May 5, 2025
MatousJobanek
approved these changes
May 6, 2025
| // - if the user has a number within the weight returned from the backend than user get's redirect to to new UI | ||
| // - if the user has a number above the weight they keep using the current UI | ||
| // | ||
| // +optional |
There was a problem hiding this comment.
just a detail, but you can add a validation of the input
Suggested change
| // +optional | |
| // +optional | |
| // +kubebuilder:validation:Minimum=0 | |
| // +kubebuilder:validation:Maximum=10 | |
| // +kubebuilder:default=10 |
There was a problem hiding this comment.
Yeah, tbh I'm not sure what range we want to use.
I though about 1 - 100.
There was a problem hiding this comment.
I've added the range (0 - 100 ) , but not the default, since that is defined in the registration service helper function.
There was a problem hiding this comment.
Yes, 1-100 is preferable IMO.
fbm3307
approved these changes
May 6, 2025
Co-authored-by: Feny Mehta <fbm3307@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new UICanaryDeploymentWeight in the toolchainconfig fields.
Jira: https://issues.redhat.com/browse/SANDBOX-1144
Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator)? yesIn case of new CRD, did you the following? N/A
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.