-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add new registration-service config param for ui canary deployement #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
18493ea
58d5d6a
3e13298
6c6f5af
d324d10
6017a76
4c9363b
870f14a
2d6bdc3
273d935
2add993
353b7d2
381e1d7
b4b540e
5ce37a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -244,6 +244,18 @@ type RegistrationServiceConfig struct { | |||||||||||
// Keeps parameters necessary for the registration service verification config | ||||||||||||
// +optional | ||||||||||||
Verification RegistrationServiceVerificationConfig `json:"verification,omitempty"` | ||||||||||||
|
||||||||||||
// UICanaryDeploymentWeight specifies the threshold of users that will be using the new UI. | ||||||||||||
// This configuration option is just a temporary solution for rolling out our new RHDH based UI using canary deployment strategy. | ||||||||||||
// Once we switch all our users to the new UI this will be removed. | ||||||||||||
// How this works: | ||||||||||||
// - backend returns a weight | ||||||||||||
// - old UI assigns a sticky random number for each user | ||||||||||||
// - if the user has a number within the weight returned from the backend than user get's redirect to to new UI | ||||||||||||
// - if the user has a number above the weight they keep using the current UI | ||||||||||||
// | ||||||||||||
// +optional | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just a detail, but you can add a validation of the input
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, tbh I'm not sure what range we want to use. I though about 1 - 100. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've added the range (0 - 100 ) , but not the default, since that is defined in the registration service helper function. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, 1-100 is preferable IMO. |
||||||||||||
UICanaryDeploymentWeight *int `json:"uiCanaryDeploymentWeight,omitempty"` | ||||||||||||
} | ||||||||||||
|
||||||||||||
// RegistrationServiceAnalyticsConfig contains the subset of registration service configuration parameters related to analytics | ||||||||||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.