-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add new registration-service config param for ui canary deployement #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
18493ea
update api version
mfrancisc 58d5d6a
Merge branch 'master' of github.com:mfrancisc/api
mfrancisc 3e13298
Merge branch 'master' of github.com:mfrancisc/api
6c6f5af
Merge branch 'master' of github.com:mfrancisc/api
d324d10
Merge branch 'master' of github.com:mfrancisc/api
6017a76
Merge branch 'master' of github.com:mfrancisc/api
4c9363b
Merge branch 'master' of github.com:mfrancisc/api
870f14a
add reasons for nstemplatetier
2d6bdc3
resolve conflicts
273d935
add new ui config
2add993
switch to in
353b7d2
Merge branch 'master' into uicanary
fbm3307 381e1d7
Update api/v1alpha1/toolchainconfig_types.go
mfrancisc b4b540e
Merge branch 'master' into uicanary
mfrancisc 5ce37a7
update
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a detail, but you can add a validation of the input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, tbh I'm not sure what range we want to use.
I though about 1 - 100.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the range (0 - 100 ) , but not the default, since that is defined in the registration service helper function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 1-100 is preferable IMO.