Skip to content

feat: add new uiconfig route #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

mfrancisc
Copy link
Contributor

This PR adds a new route GET /api/v1/uiconfig which will return configuration values to be used by the frontend applications.

Right now there is only one ( temporary ) config value : UICanaryDeploymentWeight which is being retrieved from the toolchainconfig.Host.RegistrationService.UICanaryDeploymentWeight. In the future we might have more values we want to configure that will change the behaviour of the UI.

Jira: https://issues.redhat.com/browse/SANDBOX-1144

Related to:
api: codeready-toolchain/api#476

Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.11%. Comparing base (c1faae6) to head (3bb3b53).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/configuration/configuration.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   81.10%   81.11%           
=======================================
  Files          43       44    +1     
  Lines        3520     3532   +12     
=======================================
+ Hits         2855     2865   +10     
- Misses        578      580    +2     
  Partials       87       87           
Flag Coverage Δ
unittests 81.11% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarqubecloud bot commented May 6, 2025

@mfrancisc mfrancisc merged commit 612dd33 into codeready-toolchain:master May 7, 2025
12 of 14 checks passed
@mfrancisc mfrancisc deleted the uiconfig branch May 7, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants