Skip to content

feat: add new registration-service config param for ui canary deployement #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
May 6, 2025

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented May 5, 2025

This PR adds new UICanaryDeploymentWeight in the toolchainconfig fields.

As a side effect it also updates the controller-runtime version in the CRDs.

Related to:
api: codeready-toolchain/api#476

Jira: https://issues.redhat.com/browse/SANDBOX-1144

mfrancisc and others added 30 commits December 7, 2023 12:21
Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side effect it also updates the controller-runtime version in the CRDs.

But why? Why would codeready-toolchain/api#476 trigger such controller-runtime update?

@mfrancisc
Copy link
Contributor Author

But why? Why would codeready-toolchain/api#476 trigger such controller-runtime update?

Have we maybe updated the controller-runtime without updating the version in the CRDS ?

@mfrancisc
Copy link
Contributor Author

I see the controller-gen update here : https://github.com/codeready-toolchain/host-operator/pull/1160/files , but I don't see the update to the CRDs, so I think we haven't ran make generate in api after the upgrade . Does it make sense ? cc @rsoaresd .

@alexeykazakov
Copy link
Contributor

@mfrancisc I just tried to generated a host PR for your API change: #1174

@mfrancisc
Copy link
Contributor Author

This one looks stuck on the e2e since hours now 😕

Copy link

sonarqubecloud bot commented May 6, 2025

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I see that after Rafaela merged the 4.18 updates your PR is clean now too. Feel free to merge this PR or #1174 (which are now identical). Whichever is green first :)

Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,fbm3307,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfrancisc
Copy link
Contributor Author

yeah, let's merge the one that is ready first. This one was stuck with pending e2e tests for several hours today.

@mfrancisc mfrancisc merged commit 02b916e into codeready-toolchain:master May 6, 2025
12 of 14 checks passed
@mfrancisc mfrancisc deleted the uicanary branch May 6, 2025 18:39
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.53%. Comparing base (c137181) to head (d3cd019).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1172   +/-   ##
=======================================
  Coverage   83.53%   83.53%           
=======================================
  Files          82       82           
  Lines        7927     7927           
=======================================
  Hits         6622     6622           
  Misses       1104     1104           
  Partials      201      201           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants