-
Notifications
You must be signed in to change notification settings - Fork 69
feat: add new registration-service config param for ui canary deployement #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side effect it also updates the controller-runtime version in the CRDs.
But why? Why would codeready-toolchain/api#476 trigger such controller-runtime update?
Have we maybe updated the controller-runtime without updating the version in the CRDS ? |
I see the controller-gen update here : https://github.com/codeready-toolchain/host-operator/pull/1160/files , but I don't see the update to the CRDs, so I think we haven't ran |
@mfrancisc I just tried to generated a host PR for your API change: #1174 |
This one looks stuck on the e2e since hours now 😕 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I see that after Rafaela merged the 4.18 updates your PR is clean now too. Feel free to merge this PR or #1174 (which are now identical). Whichever is green first :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yeah, let's merge the one that is ready first. This one was stuck with pending e2e tests for several hours today. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
=======================================
Coverage 83.53% 83.53%
=======================================
Files 82 82
Lines 7927 7927
=======================================
Hits 6622 6622
Misses 1104 1104
Partials 201 201 🚀 New features to boost your workflow:
|
This PR adds new
UICanaryDeploymentWeight
in thetoolchainconfig
fields.As a side effect it also updates the controller-runtime version in the CRDs.
Related to:
api: codeready-toolchain/api#476
Jira: https://issues.redhat.com/browse/SANDBOX-1144