boards: silabs: Add support for Silabs EFR32ZG28 SoC #89597

shontal1005 · 2025-05-07T11:27:38Z

Adds support for Silicon Labs EFR32ZG28 SoC and BRD4401C Radio Board.

github-actions · 2025-05-07T11:28:19Z

Hello @shontal1005, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

kartben

this is missing a documentation page
see https://github.com/zephyrproject-rtos/zephyr/blob/76e1fc7713a4a3f2b50c497afddec0364a34c10b/doc/templates/board.tmpl or other SiLabs boards for examples

Thanks!

modules/hal_silabs/Kconfig

jerome-pouiller · 2025-05-07T12:20:41Z

The commit is large. Would you mind to split it in two parts (or more)? Maybe one commit for the soc and one commit for the board?

BTW, don't this PR require any change on the hal? If yes, you need to update west.yml.

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c_deconfig

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c-pinctrl.dtsi

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.yaml

dts/arm/silabs/efr32xg28.dtsi

nordicjm · 2025-05-08T09:09:34Z

dts/arm/silabs/efr32xg28.dtsi

+			compatible = "fixed-factor-clock";
+			clocks = <&lfrco>;
+		};
+		wdog0clk: wdog0clk {


peripherals need to be disabled in the base dts file, then enabled as-needed by boards

It seems that on all other platforms the peripherals are not disabled

dts/arm/silabs/efr32zg28b322f1024im68.dtsi

nordicjm · 2025-05-08T09:10:23Z

soc/silabs/silabs_s2/efr32zg28/Kconfig

+config SOC_GECKO_SDID
+	default 235 if SOC_SERIES_EFR32ZG28


if this is an existing symbol, put it in Kconfig.defconfig

I don't understand, it seems like all the other platforms do the same thing as I did

Then they need to move Kconfig adds new symbols, if you are changing the default of an existing symbol then it goes in Kconfig.defconfig

@shontal1005, do you want to carry this change or you prefer I open a PR?

If the change I made is what you meant, I can open another PR.

boards/silabs/radio_boards/xg28_rb4401c/doc/index.rst

Martinhoff-maker

Sorry for the late review, only few comments but otherwise LGTM. Don't forget to resolve the compliance problem.

dts/arm/silabs/xg28/efr32zg28b322f1024im68.dtsi

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts

boards/silabs/radio_boards/xg28_rb4401c/doc/index.rst

Add support for Silicon Labs EFR32ZG28 SoC. Signed-off-by: Shontal Biton <shontal1005@gmail.com>

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts

Add support for Silicon Labs BRD4401C (a.k.a xG28-RB4401C) Radio Board. Signed-off-by: Shontal Biton <shontal1005@gmail.com>

Martinhoff-maker · 2025-07-16T15:55:03Z

FYI: I've created a PR to resolve the CI failure.

Added support for xg28 in eeprom test. Signed-off-by: Shontal Biton <shontal1005@gmail.com>

sonarqubecloud · 2025-07-16T16:41:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.1% Duplication on New Code

See analysis details on SonarQube Cloud

asmellby · 2025-07-17T07:57:05Z

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts

+&dcdc {
+	regulator-boot-on;
+	regulator-initial-mode = <SILABS_DCDC_MODE_BUCK>;
+	silabs,pfmx-peak-current-milliamp = <80>;


In SiSDK, the default peak current is set to 100 mA on xG28: https://github.com/SiliconLabs/simplicity_sdk/blob/v2025.6.0/platform/service/device_init/config/s2/sdid235/20dbm/sl_device_init_dcdc_config.h#L54
Is there a reason it's different here?

asmellby · 2025-07-17T07:58:19Z

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts

+};
+
+&hfxo {
+	ctune = <106>;


In SiSDK, the HFXO tuning value is 115 for this board: https://github.com/SiliconLabs/simplicity_sdk/blob/v2025.6.0/hardware/board/config/brd4401c_brd4002a/sl_device_init_hfxo_config.h#L53

asmellby · 2025-07-17T07:58:35Z

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts

+};
+
+&lfxo {
+	ctune = <38>;


In SiSDK, the LFXO tuning value is 44 for this board: https://github.com/SiliconLabs/simplicity_sdk/blob/v2025.6.0/hardware/board/config/brd4401c_brd4002a/sl_device_init_lfxo_config.h#L46

asmellby · 2025-07-17T08:01:00Z

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c_defconfig

+CONFIG_UART_CONSOLE=y
+CONFIG_SERIAL=y
+CONFIG_GPIO=y
+CONFIG_SOC_GECKO_EMU_DCDC=y


These two DCDC options aren't used on Series 2, and should be removed.

asmellby · 2025-07-17T08:07:33Z

dts/arm/silabs/xg28/xg28.dtsi

+				status = "disabled";
+			};
+
+			gpiod: gpio@5003c0C0 {


nit: inconsistent capitalization of the unit address

asmellby · 2025-07-17T08:07:53Z

dts/arm/silabs/xg28/xg28.dtsi

+
+			gpiod: gpio@5003c0C0 {
+				compatible = "silabs,gecko-gpio-port";
+				reg = <0x5003c0C0 0x30>;


nit: inconsistent capitalization of the register address

github-actions bot added area: Pinctrl area: Clock Control platform: Silabs Silicon Labs labels May 7, 2025

github-actions bot requested review from asmellby, gmarull, jerome-pouiller, jhedberg, Martinhoff-maker, mnkp, nordic-krch, rettichschnidi and yonsch May 7, 2025 11:28

github-actions bot assigned nordic-krch May 7, 2025

jhedberg assigned jhedberg and asmellby and unassigned nordic-krch May 7, 2025

kartben previously requested changes May 7, 2025

View reviewed changes

jerome-pouiller reviewed May 7, 2025

View reviewed changes

modules/hal_silabs/Kconfig Outdated Show resolved Hide resolved

jerome-pouiller reviewed May 7, 2025

View reviewed changes

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c_deconfig Outdated Show resolved Hide resolved

nordicjm requested changes May 8, 2025

View reviewed changes

shontal1005 force-pushed the main branch from f820ef7 to 2b9fe1f Compare May 11, 2025 20:04

github-actions bot added area: UART Universal Asynchronous Receiver-Transmitter area: ADC Analog-to-Digital Converter (ADC) labels May 11, 2025

github-actions bot requested review from anangl and dcpleung May 11, 2025 20:05

kartben reviewed May 11, 2025

View reviewed changes

boards/silabs/radio_boards/xg28_rb4401c/doc/index.rst Show resolved Hide resolved

rettichschnidi removed their request for review May 12, 2025 07:40

shontal1005 force-pushed the main branch from 2b9fe1f to d1c53b0 Compare May 12, 2025 12:47

shontal1005 force-pushed the main branch 3 times, most recently from 7248fcf to 6c91b24 Compare July 6, 2025 07:08

shontal1005 changed the title ~~boards: silabs: Add support for SiLabs EFR32ZG28 SoC~~ boards: silabs: Add support for Silabs EFR32ZG28 SoC Jul 6, 2025

shontal1005 force-pushed the main branch from 6c91b24 to 4d5a15c Compare July 8, 2025 12:08

github-actions bot added the area: DMA Direct Memory Access label Jul 8, 2025

github-actions bot requested a review from teburd July 8, 2025 12:09

shontal1005 force-pushed the main branch from 4d5a15c to 0e22d75 Compare July 9, 2025 09:35

shontal1005 requested a review from jerome-pouiller July 9, 2025 13:09

Martinhoff-maker reviewed Jul 11, 2025

View reviewed changes

shontal1005 force-pushed the main branch 6 times, most recently from 7ec7292 to 98db4fd Compare July 13, 2025 11:52

yishai1999 suggested changes Jul 14, 2025

View reviewed changes

boards/silabs/radio_boards/xg28_rb4401c/doc/index.rst Outdated Show resolved Hide resolved

shontal1005 requested a review from Martinhoff-maker July 14, 2025 14:46

soc: silabs: Add support for Silabs EFR32ZG28 SoC

545c10f

Add support for Silicon Labs EFR32ZG28 SoC. Signed-off-by: Shontal Biton <shontal1005@gmail.com>

shontal1005 force-pushed the main branch 2 times, most recently from 83c55f7 to b603287 Compare July 15, 2025 07:27

Martinhoff-maker reviewed Jul 15, 2025

View reviewed changes

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts Outdated Show resolved Hide resolved

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts Outdated Show resolved Hide resolved

boards/silabs/radio_boards/xg28_rb4401c/xg28_rb4401c.dts Outdated Show resolved Hide resolved

boards: silabs: Add support for Silabs EFR32ZG28 BRD4401C board

2a4547c

Add support for Silicon Labs BRD4401C (a.k.a xG28-RB4401C) Radio Board. Signed-off-by: Shontal Biton <shontal1005@gmail.com>

shontal1005 force-pushed the main branch from b603287 to 2a4547c Compare July 16, 2025 11:32

Martinhoff-maker mentioned this pull request Jul 16, 2025

tests: build_all: eeprom: change config for compatibility #93211

Open

tests: eeprom: Added support for xg28

262e5a8

Added support for xg28 in eeprom test. Signed-off-by: Shontal Biton <shontal1005@gmail.com>

github-actions bot added the area: EEPROM label Jul 16, 2025

asmellby reviewed Jul 17, 2025

View reviewed changes

boards: silabs: Add support for Silabs EFR32ZG28 SoC #89597

Are you sure you want to change the base?

boards: silabs: Add support for Silabs EFR32ZG28 SoC #89597

Conversation

shontal1005 commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 7, 2025

Uh oh!

kartben left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jerome-pouiller commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Martinhoff-maker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Martinhoff-maker commented Jul 16, 2025

Uh oh!

sonarqubecloud bot commented Jul 16, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shontal1005 commented May 7, 2025 •

edited

Loading

jerome-pouiller commented May 7, 2025 •

edited

Loading