-
Notifications
You must be signed in to change notification settings - Fork 21
[CAL][6] - move SourceChainConfig to chainaccessor types #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ogtownsend
merged 2 commits into
main
from
ogt/cal-6-migrate-SourceChainConfig-to-types-package
Jun 10, 2025
Merged
[CAL][6] - move SourceChainConfig to chainaccessor types #989
ogtownsend
merged 2 commits into
main
from
ogt/cal-6-migrate-SourceChainConfig-to-types-package
Jun 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2025
1b6d466 to
174b745
Compare
174b745 to
f602873
Compare
41b141c to
f546d1d
Compare
f602873 to
2cd0e4c
Compare
winder
reviewed
Jun 9, 2025
winder
requested changes
Jun 9, 2025
Contributor
winder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a file is missing from the diff.
f67b578 to
c80ead1
Compare
2cd0e4c to
eee2b6a
Compare
winder
approved these changes
Jun 10, 2025
|
huangzhen1997
approved these changes
Jun 10, 2025
This was referenced Jun 10, 2025
Merged
This was referenced Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core ref: aad88a584c81e0be68f68927d5ab041fc65ca646
SourceChainConfigdefinition in ccip.go in favor of the one defined inpkg/types/ccipocr3/chain_accessor.gosince we will need this inlegacy_accessor.goStack: