Skip to content

Conversation

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Metric ogt/cal-8-rename-LegacyAccessor-and-update-contract-writer-mock ogt/cal-7-implement-GetExpectedNextSequenceNumber
Coverage 71.9% 71.5%

// CRCWAccessor is an implementation of cciptypes.ChainAccessor that allows the CCIPReader
// to cutover and migrate away from depending directly on contract reader and contract writer.
type LegacyAccessor struct {
type CRCWAccessor struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I like the name "GenericAccessor" slightly more than CRCWAccessor because we could have multiple accessors implemented with CR/CW. But up to you if you like this better.

winder
winder previously approved these changes Jun 9, 2025
@ogtownsend ogtownsend force-pushed the ogt/cal-7-implement-GetExpectedNextSequenceNumber branch from 8dabb7d to ac227a3 Compare June 10, 2025 18:42
Base automatically changed from ogt/cal-7-implement-GetExpectedNextSequenceNumber to ogt/cal-6-migrate-SourceChainConfig-to-types-package June 10, 2025 18:52
@ogtownsend ogtownsend changed the base branch from ogt/cal-6-migrate-SourceChainConfig-to-types-package to main June 10, 2025 20:10
@ogtownsend ogtownsend dismissed winder’s stale review June 10, 2025 20:10

The base branch was changed.

@ogtownsend ogtownsend closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants