-
Notifications
You must be signed in to change notification settings - Fork 21
[CAL][1] - Add initial CAL scaffolding to CCIPReader with legacy accessor #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17bce4b to
d7c538d
Compare
633143f to
23b5f00
Compare
huangzhen1997
previously approved these changes
Jun 5, 2025
ogtownsend
commented
Jun 5, 2025
23b5f00 to
43164c4
Compare
This was referenced Jun 6, 2025
bef5007 to
25cef37
Compare
|
winder
reviewed
Jun 9, 2025
winder
reviewed
Jun 9, 2025
winder
approved these changes
Jun 9, 2025
Contributor
winder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made two suggestions that I think you should take, but they can be implemented as followups.
This was referenced Jun 10, 2025
Merged
This was referenced Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core ref: 7404f6349ac2bdb222f3c5889669d98760920168
CCIPReader --> CR/CWtoCCIPReader --> CALon a per-function basis.Stack: