Skip to content

Conversation

@ogtownsend
Copy link
Contributor

@ogtownsend ogtownsend commented Jun 4, 2025

core ref: 7404f6349ac2bdb222f3c5889669d98760920168

  • Add initial support for the chain accessor to ccip.go (CCIPReader)
  • Merging the skeleton with the outlined and unimplemented functions should allow us to more easily chip away at the migration from CCIPReader --> CR/CW to CCIPReader --> CAL on a per-function basis.
  • Taking this approach where we can test incrementally should ideally be less risky than a single PR where all functions are migrated at once
  • For more context, see NONEVM-1865

Stack:

  1. [CAL][1] - Add initial CAL scaffolding to CCIPReader with legacy accessor #978
  2. [CAL][2] - Implement Metadata() and GetContractAddress() #980
  3. [CAL][3] - Implement GetChainFeeComponents #985
  4. [CAL][4] - Implement MsgsBetweenSeqNums() function in accessor #987
  5. [CAL][5] - implement LatestMsgSeqNum #988
  6. [CAL][6] - move SourceChainConfig to chainaccessor types #989
  7. [CAL][7] - implement GetExpectedNextSequenceNumber #990
  8. [CAL][8] - Some minor cleanup and renaming #999
  9. [CAL][9] - Implement CommitReportsGTETimestamp, GetTokenPriceUSD, and GetLatestPriceSeqNr #1000
  10. [CAL][10] - Implement Nonces and GetChainFeePriceUpdate #1014
  11. [CAL][11] - Implement ExecutedMessages for chain accessor #1017

@ogtownsend ogtownsend requested a review from winder June 4, 2025 20:39
@ogtownsend ogtownsend force-pushed the ogt/cal-initial-scaffolding-in-ccip-reader branch 2 times, most recently from 17bce4b to d7c538d Compare June 4, 2025 21:44
@ogtownsend ogtownsend marked this pull request as ready for review June 4, 2025 22:19
@ogtownsend ogtownsend requested a review from a team as a code owner June 4, 2025 22:19
@ogtownsend ogtownsend changed the title Add initial CAL scaffolding to CCIPReader with legacy accessor [CAL] Add initial CAL scaffolding to CCIPReader with legacy accessor Jun 4, 2025
@ogtownsend ogtownsend marked this pull request as draft June 4, 2025 22:44
@ogtownsend ogtownsend force-pushed the ogt/cal-initial-scaffolding-in-ccip-reader branch from 633143f to 23b5f00 Compare June 4, 2025 22:57
@ogtownsend ogtownsend marked this pull request as ready for review June 4, 2025 23:24
@ogtownsend ogtownsend changed the title [CAL] Add initial CAL scaffolding to CCIPReader with legacy accessor [CAL][1] Add initial CAL scaffolding to CCIPReader with legacy accessor Jun 4, 2025
@ogtownsend ogtownsend changed the title [CAL][1] Add initial CAL scaffolding to CCIPReader with legacy accessor [CAL][1] - Add initial CAL scaffolding to CCIPReader with legacy accessor Jun 4, 2025
huangzhen1997
huangzhen1997 previously approved these changes Jun 5, 2025
@ogtownsend ogtownsend force-pushed the ogt/cal-initial-scaffolding-in-ccip-reader branch from 23b5f00 to 43164c4 Compare June 5, 2025 17:04
@ogtownsend ogtownsend force-pushed the ogt/cal-initial-scaffolding-in-ccip-reader branch from bef5007 to 25cef37 Compare June 9, 2025 14:33
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Metric ogt/cal-initial-scaffolding-in-ccip-reader main
Coverage 72.3% 72.1%

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two suggestions that I think you should take, but they can be implemented as followups.

@ogtownsend ogtownsend added this pull request to the merge queue Jun 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2025
@ogtownsend ogtownsend added this pull request to the merge queue Jun 9, 2025
@ogtownsend ogtownsend removed this pull request from the merge queue due to a manual request Jun 9, 2025
@ogtownsend ogtownsend added this pull request to the merge queue Jun 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2025
@ogtownsend ogtownsend added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit 67b0126 Jun 9, 2025
45 checks passed
@winder winder deleted the ogt/cal-initial-scaffolding-in-ccip-reader branch June 9, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants