Skip to content

Conversation

@ogtownsend ogtownsend changed the base branch from main to ogt/cal-11-implement-ExecutedMessages June 18, 2025 00:06
@ogtownsend ogtownsend force-pushed the ogt/cal-12-implement-Sync branch from 64a3426 to 7e9f6a3 Compare June 20, 2025 04:12
@ogtownsend ogtownsend changed the base branch from ogt/cal-11-implement-ExecutedMessages to main June 20, 2025 04:12
@ogtownsend ogtownsend force-pushed the ogt/cal-12-implement-Sync branch from 7e9f6a3 to 3318f03 Compare June 20, 2025 21:40
@github-actions
Copy link

Metric ogt/cal-12-implement-Sync main
Coverage 70.0% 69.9%

@ogtownsend ogtownsend marked this pull request as ready for review June 20, 2025 21:54
@ogtownsend ogtownsend requested a review from a team as a code owner June 20, 2025 21:54
Comment on lines +132 to +134
// Deprecated
// TODO(NONEVM-1865): Remove once the chainAccessor is passed down here from the factory. Then use accessor.Sync().
func bindReaderContract[T contractreader.ContractReaderFacade](
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @winder , I relocated this function here since USDC reader is still using it, but marked it deprecated. I looked into initializing the the CAL objects within this reader but it requires piping the contract writers down here from way above in the plugin factory so figured that's probably better done in its own PR.

@ogtownsend ogtownsend added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 06262c0 Jun 23, 2025
47 checks passed
@ogtownsend ogtownsend deleted the ogt/cal-12-implement-Sync branch June 23, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants