-
Notifications
You must be signed in to change notification settings - Fork 21
[CAL][4] - Implement MsgsBetweenSeqNums() function in accessor #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAL][4] - Implement MsgsBetweenSeqNums() function in accessor #987
Conversation
85b4921 to
d599a96
Compare
361270d to
8bf7dd6
Compare
c2b4160 to
9e3d292
Compare
| cciptypes "github.com/smartcontractkit/chainlink-ccip/pkg/types/ccipocr3" | ||
| ) | ||
|
|
||
| func ValidateSendRequestedEvent( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how much of this would be common across other accessors. Most of these checks could be done in the CCIPReader, may be worth moving them there in a followup PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I guess this shouldn't really be chain-specific. I created NONEVM-1996
winder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small changes. Mainly not putting SendRequestedEvent into the ccipocr3 package.
9e3d292 to
8f950d6
Compare
8bf7dd6 to
a096ee4
Compare
|
da52270
into
ogt/cal-3-implement-get-chain-fee-components
* [CAL][3] - Implement GetChainFeeComponents * [CAL][4] - Implement MsgsBetweenSeqNums() function in accessor (#987)
core ref: aad88a584c81e0be68f68927d5ab041fc65ca646
Stack: