Skip to content

Conversation

@ogtownsend ogtownsend marked this pull request as ready for review June 6, 2025 18:41
@ogtownsend ogtownsend requested review from a team, 0xnogo, AmrMohamedRezk, archseer, asoliman92, dimkouv, huangzhen1997, krebernisak, makramkd, matYang and winder and removed request for a team June 6, 2025 18:41
@ogtownsend ogtownsend force-pushed the ogt/cal-3-implement-get-chain-fee-components branch from 85b4921 to d599a96 Compare June 9, 2025 14:34
@ogtownsend ogtownsend force-pushed the ogt/cal-4-implement-msgs-between-seq-nums branch from 361270d to 8bf7dd6 Compare June 9, 2025 14:42
@ogtownsend ogtownsend force-pushed the ogt/cal-3-implement-get-chain-fee-components branch 3 times, most recently from c2b4160 to 9e3d292 Compare June 9, 2025 20:26
cciptypes "github.com/smartcontractkit/chainlink-ccip/pkg/types/ccipocr3"
)

func ValidateSendRequestedEvent(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how much of this would be common across other accessors. Most of these checks could be done in the CCIPReader, may be worth moving them there in a followup PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I guess this shouldn't really be chain-specific. I created NONEVM-1996

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small changes. Mainly not putting SendRequestedEvent into the ccipocr3 package.

@ogtownsend ogtownsend force-pushed the ogt/cal-3-implement-get-chain-fee-components branch from 9e3d292 to 8f950d6 Compare June 9, 2025 21:22
@ogtownsend ogtownsend force-pushed the ogt/cal-4-implement-msgs-between-seq-nums branch from 8bf7dd6 to a096ee4 Compare June 9, 2025 21:37
@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Metric ogt/cal-4-implement-msgs-between-seq-nums ogt/cal-3-implement-get-chain-fee-components
Coverage 72.1% 71.6%

@ogtownsend ogtownsend merged commit da52270 into ogt/cal-3-implement-get-chain-fee-components Jun 9, 2025
36 of 53 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jun 9, 2025
* [CAL][3] - Implement GetChainFeeComponents

* [CAL][4] - Implement MsgsBetweenSeqNums() function in accessor (#987)
@ogtownsend ogtownsend deleted the ogt/cal-4-implement-msgs-between-seq-nums branch June 17, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants