Cache refactoring #135
Cache refactoring #135
Conversation
Fix: phpcs issues with naming standard
There was a problem hiding this comment.
@AleTorrisi Let's resolve the merge conflicts and double-check that all the features are working as expected. I noticed the tests caught something and are failing with a 500 Internal Server Error, let's look into that too. Thanks!
# Conflicts: # includes/Cache/CacheManager.php # includes/Performance.php
Fix: 404 error on Jetpack Boost preloading when Jetpack Boost is not active
There was a problem hiding this comment.
Needs to go with:
newfold-labs/wp-module-onboarding-data#137
newfold-labs/wp-module-onboarding-data#140
newfold-labs/wp-module-hosting#19
newfold-labs/wp-plugin-bluehost#134
Other plugins:
newfold-labs/wp-plugin-hostgator#1014
newfold-labs/wp-plugin-crazy-domains#613
newfold-labs/wp-plugin-web#477
newfold-labs/wp-plugin-mojo#463
Thanks! @AleTorrisi, looks good to me! Much, much cleaner than the code before 😄.
Let’s resolve the merge conflict and get this thoroughly tested by QA, since it involves changes across multiple plugins and modules. We’ll want to make sure everything is working as expected before we merge it.
# Conflicts: # includes/Cache/Types/Cloudflare.php
|
I'll fix the lint in #156 |
Proposed changes
This branch introduces a new organization of the code about Cache feature. The main goal is handle cache functions as single feature as already happens for LinkPrefect and JetPackBoost in example.
No new feature has been introduced, just a code refactoring.
New folder is available now: wp-module-performance/includes/Cache
Type of Change
Production
Development
Video
Checklist
Further comments