Skip to content

Decouple Performance Page from Brand Plugin and Add Standalone Tools Integration #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 2, 2025

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Mar 31, 2025

Proposed changes

This PR moves the Performance page from the Brand Plugin App Nav to its own standalone page under the Tools menu in the WordPress admin.

This requires thorough testing because:

  1. We now use our own Tailwind and PostCSS setup along with the Newfold UI library, and no longer rely on the plugin’s styling pipeline.
  2. We have implemented dynamic brand support using CSS variables, allowing the page to adapt its appearance based on the active brand without depending on the plugin. (We will eventually need to move branding to a common location. I'll discuss this with the plugins team. For now, this serves as a reference implementation. I also have a few ideas on how we can standardize this across modules.)
  3. We’ve created a custom Redux store specifically for the performance module, removing any dependency on the plugin’s store.
  4. We use separate Webpack configurations for building both the general-purpose JS assets and the React SPA, replacing the plugin’s build system.
  5. This is a completely standalone implementation. We no longer rely on any plugin components, methods, or utilities in any way.
image

Note: This needs to go out after #135

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 mentioned this pull request Apr 2, 2025
14 tasks
Base automatically changed from cache-refactoring to main April 2, 2025 10:27
@arunshenoy99 arunshenoy99 merged commit f009d67 into main Apr 2, 2025
2 of 7 checks passed
@arunshenoy99 arunshenoy99 deleted the enhance/add-standalone-performance-page branch April 2, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants