-
Notifications
You must be signed in to change notification settings - Fork 2
Move Rest API to performance module #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Rest API to performance module #134
Conversation
Looks good, once that performance module PR is merged and a version is tagged we can update it in this PR to make sure tests are all passing with the removed code. Then we can merge it in! |
thanks @circlecube |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires newfold-labs/wp-module-onboarding-data#140 to be merged and released, as it's currently blocking an update to the performance module here.
…luehost into PRESS7-291-remove-useless-code-performance-module
Merging this into the performance bump branch, which can actually support it along with all the other module updates that include support for the refactoring. This branch should get tests working |
Proposed changes
This PR works in combination with this one for Performance module.
The goal is delegate everything to that module and remove useless code in the brand plugin.
Type of Change
Production
Development
Video
Checklist
Further comments