Skip to content

Move Rest API to performance module #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AleTorrisi
Copy link
Contributor

Proposed changes

This PR works in combination with this one for Performance module.
The goal is delegate everything to that module and remove useless code in the brand plugin.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube
Copy link
Member

Looks good, once that performance module PR is merged and a version is tagged we can update it in this PR to make sure tests are all passing with the removed code. Then we can merge it in!

@AleTorrisi
Copy link
Contributor Author

thanks @circlecube

@circlecube circlecube modified the milestones: April 2, 2025 Release, April 9, 2025 Release Mar 25, 2025
@arunshenoy99 arunshenoy99 changed the base branch from main to develop April 7, 2025 06:29
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires newfold-labs/wp-module-onboarding-data#140 to be merged and released, as it's currently blocking an update to the performance module here.

@arunshenoy99 arunshenoy99 changed the base branch from develop to main April 8, 2025 09:55
@arunshenoy99 arunshenoy99 changed the base branch from main to develop April 8, 2025 09:55
…luehost into PRESS7-291-remove-useless-code-performance-module
@arunshenoy99 arunshenoy99 changed the base branch from develop to update/performance April 8, 2025 09:59
@arunshenoy99
Copy link
Member

arunshenoy99 commented Apr 8, 2025

Merging this into the performance bump branch, which can actually support it along with all the other module updates that include support for the refactoring. This branch should get tests working

@arunshenoy99 arunshenoy99 merged commit 807474a into update/performance Apr 8, 2025
3 of 5 checks passed
@arunshenoy99 arunshenoy99 deleted the PRESS7-291-remove-useless-code-performance-module branch April 8, 2025 10:00
@circlecube circlecube modified the milestones: April 9, 2025 Release, April 16, 2025 Release Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants