Skip to content

Fix Fatal Error in shouldEnable #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Fix Fatal Error in shouldEnable #144

merged 2 commits into from
Mar 24, 2025

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Story: https://jira.newfold.com/browse/PRESS7-331

Should also be taken care of in #135, but this is needed for the Hosting Panel MVP release, which is planned to go out earlier.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 merged commit 580e4a6 into main Mar 24, 2025
7 checks passed
@arunshenoy99 arunshenoy99 deleted the bugfix/cf-fatal-error branch March 24, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants