Skip to content

Move Rest API to performance module #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

AleTorrisi
Copy link

This PR works in combination with newfold-labs/wp-module-performance#135 for Performance module.
The goal is delegate everything to that module and remove useless code in the brand plugin.

Proposed changes

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • [] I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

cypress bot commented Mar 21, 2025

HostGator Plugin    Run #6030

Run Properties:  status check failed Failed #6030  •  git commit 80daa8c8eb ℹ️: Merge d3c57a2ab8f53b9ecdd6aedeb7264019c20aefcc into 184383d3d396b41a64e6ceeb1bd0...
Project HostGator Plugin
Branch Review support-for-cache-refactoring
Run status status check failed Failed #6030
Run duration 34m 46s
Commit git commit 80daa8c8eb ℹ️: Merge d3c57a2ab8f53b9ecdd6aedeb7264019c20aefcc into 184383d3d396b41a64e6ceeb1bd0...
Committer Alessio Torrisi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 29
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 313
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-performance/tests/cypress/integration/performance.cy.js • 1 failed test

View Output Video

Test Artifacts
Performance Page > Clear Cache Button Functions Test Replay Screenshots Video

@arunshenoy99 arunshenoy99 changed the base branch from main to update/performance April 11, 2025 08:05
@arunshenoy99 arunshenoy99 merged commit aeb7a8c into update/performance Apr 11, 2025
1 of 2 checks passed
@arunshenoy99 arunshenoy99 deleted the support-for-cache-refactoring branch April 11, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants