Fix cellular_status message definition

[MaEtUgR]

Solved Problem

When discussing about message documentation in https://discordapp.com/channels/1022170275984457759/1354222673953030376/1354222677577044171 I found that there are plenty of bad examples so I picked one that's even somewhat debatable why we keep it in PX4 to just check how I'd improve the description without even knowing the exact was the message is used. This is just an example.

Solution

• enums have field name prefix and ar listed directly below
• enum option values have the type of the field
• for bit fields the individual flag's definition has the value to mask that bit
• fields that are defined as enum like type here actually have the options properly defined
• FLAG_FAILED=1 # velocity setpoint wtf?
• no dubious alignment attempts, one space to separate names, operators, comments

Changelog Entry

Fix cellular_status message definition

Test coverage

This compiles and should not change the usage within PX4, also it's not a versioned message and I didn't change any field name.

[hamishwillee]

Looks so much better - see comments inline.

As an aside, I did see one case elsewhere that had multi-line comments. So something like

uint fred # comment line one
    # comment line two
    # comment line two
uint new_token

[hamishwillee]

OK, updated as discussed offline. I think it works. Open question here: https://github.com/PX4/PX4-Autopilot/pull/24662/files#r2069771839

Because I didn't mean to add one.

[MaEtUgR]

Nice, your changes make sense to me 👍 Can't approve since it's my own pr but I would if I could.

[hamishwillee]

I can approve it :-)

[hamishwillee]

Thanks @MaEtUgR !!!