ActuatorMotors.msg - uORB docs #24818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
May 8, 2025
| uint16 reversible_flags # bitset which motors are configured to be reversible | ||
| uint16 reversible_flags # Bitset indicating which motors are configured to be reversible | ||
|
|
||
| uint8 ACTUATOR_FUNCTION_MOTOR1 = 101 |
There was a problem hiding this comment.
What is this and where is it used?
There was a problem hiding this comment.
@MaEtUgR ^^^ This still looks weird. Needs explanation.
There was a problem hiding this comment.
But if not, let's still merge!
hamishwillee
commented
May 8, 2025
hamishwillee
commented
May 8, 2025
MaEtUgR
reviewed
May 8, 2025
|
@MaEtUgR I think ready for another look. The question in #24818 (comment) is still open. |
hamishwillee
commented
May 14, 2025
This was referenced May 14, 2025
hamishwillee
force-pushed
the
hamishwillee-actuator_motors
branch
from
c497add to
0f27959
Compare
Co-authored-by: Matthias Grob <maetugr@gmail.com>
Co-authored-by: Matthias Grob <maetugr@gmail.com>
Co-authored-by: PX4 Build Bot <bot@px4.io>
hamishwillee
force-pushed
the
hamishwillee-actuator_motors
branch
from
63e19a5 to
635c360
Compare
|
I am self merging. It matches our standard, and doesn't change anything else. So it is no worse than before, and a bit better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up the ActuatorMotors UORB topic to match the evolving doc standard (for similar, see #24662 , #24789).
Solution
Enum values after the field that uses them[<value>]to mark units[@enum <value>]to mark allowed values[@range <minValue>,<maxValue>]to mark ranges - inclusive[@invalid <value>]to mark the invalid/not-supplied valueChangelog Entry
For release notes:
Other comments
See inline notes