Skip to content

[vpj] Push Job Timeout #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 22, 2025
Merged

Conversation

KaiSernLim
Copy link
Contributor

@KaiSernLim KaiSernLim commented May 12, 2025

Venice Push Job Diagram as a refresher:
VPJ-Diagram

Problem Statement

There is no timeout on the Compute Engine DataWriterComputeJob. This leads to some push jobs taking days and even sometimes weeks to complete, which significantly delays the debugging process. There is an existing timeout (bootstrapToOnlineTimeoutInHours) on the job status polling, but that takes place after the data writer job portion (which is where we've been witnessing significant delays). With the increased frequency of KIF repushes, this issue will become even more pronounced.

Solution

There should be a timeout on the entire push job as a whole. If exceeded, the push job should be cancelled. The existing configuration bootstrapToOnlineTimeoutInHours can be repurposed for this, and this should've be the original purpose of the configuration.

Concurrency-Specific Checks

Both reviewer and PR author to verify

  • Code has no race conditions or thread safety issues.
  • No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
  • Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
  • Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

  • New unit tests added.
  • Added testPushJobTimeout() which tests the poll job status gets cancelled.
  • Added testDataWriterComputeJobTimeout() which tests the data writer job gets killed.
  • Deprecated testPushJobPollStatus() and testPushJobUnknownPollStatusDoesWaiting(), which pertained to the old usage of the bootstrapToOnlineTimeoutInHours configuration.

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.

@KaiSernLim KaiSernLim self-assigned this May 12, 2025
@KaiSernLim KaiSernLim force-pushed the vpj-datawriterjob-timeout branch from 69bde8d to e02f96c Compare May 19, 2025 19:22
Copy link
Contributor

@nisargthakkar nisargthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments in tests. But main code change LGTM

nisargthakkar
nisargthakkar previously approved these changes May 21, 2025
Copy link
Contributor

@nisargthakkar nisargthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @KaiSernLim!

Copy link
Contributor

@nisargthakkar nisargthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the dilligence @KaiSernLim!

@KaiSernLim KaiSernLim merged commit c42ca87 into linkedin:main May 22, 2025
58 checks passed
@KaiSernLim KaiSernLim deleted the vpj-datawriterjob-timeout branch May 22, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants