Code

[vpj] Push Job Timeout#1786

Code

Merged

KaiSernLim merged 20 commits intolinkedin:mainlinkedin/venice:mainfrom

KaiSernLim:vpj-datawriterjob-timeoutKaiSernLim/venice:vpj-datawriterjob-timeoutCopy head branch name to clipboard

May 22, 2025

Commits

Commits on May 19, 2025

• Removed old `bootstrapToOnlineOnlineTimeoutInHours` usage since it's being applied to the start of the push job from now on. 🐔

  KaiSernLim

  committed
  8ebedc2

  Copy full SHA for 8ebedc2

• First attempt at adding a timeout to cancel the job. 🌗

  KaiSernLim

  committed
  dddea75

  Copy full SHA for dddea75

• Implement timeout handling for VenicePushJob and add unit test for timeout behavior. 🐏

  KaiSernLim

  committed
  82a2c2d

  Copy full SHA for 82a2c2d

• Two unit tests for verification. 🚏

  KaiSernLim

  committed
  cf391b1

  Copy full SHA for cf391b1

• Fixed the unit test to actually test something meaningful. 🎤

  KaiSernLim

  committed
  387ff49

  Copy full SHA for 387ff49

• Fixed NPE from `storeResponse` not being populated. 🦆

  KaiSernLim

  committed
  12902db

  Copy full SHA for 12902db

• Fixed Spotbugs warning in test. 🥱

  KaiSernLim

  committed
  3d1f33d

  Copy full SHA for 3d1f33d

• Fixed `controllerClient` NPE. 🐻‍❄️

  KaiSernLim

  committed
  7cc99a3

  Copy full SHA for 7cc99a3

• Refactored `timeoutExecutor` to be a member variable. 🫩

  KaiSernLim

  committed
  e02f96c

  Copy full SHA for e02f96c

Commits on May 20, 2025

• Minor review changes by Nisarg. 🪡

  KaiSernLim

  committed
  210c28c

  Copy full SHA for 210c28c

Commits on May 21, 2025

• Try setting `bootstrapToOnlineTimeoutInHours` directly, instead of relying on `storeResponse`. 🥸

  KaiSernLim

  committed
  eac4a66

  Copy full SHA for eac4a66

• Revert "Try setting `bootstrapToOnlineTimeoutInHours` directly, instead of relying on `storeResponse`. 🥸"

  Show description for 5540f7f
  KaiSernLim

  committed
  5540f7f

  Copy full SHA for 5540f7f

• Try changing the condition in the test. 😪

  KaiSernLim

  committed
  2f9f9fe

  Copy full SHA for 2f9f9fe

• Only check `KILLED` status in unit test. 🤖

  KaiSernLim

  committed
  07d8ab9

  Copy full SHA for 07d8ab9

Commits on May 22, 2025

• I can't tell which branches the unit test is going into in CI. 😭

  KaiSernLim

  committed
  eca6ef3

  Copy full SHA for eca6ef3

• Is the latch even counting down? 😭

  KaiSernLim

  committed
  74da931

  Copy full SHA for 74da931

• Is the latch even counting down? 😭

  KaiSernLim

  committed
  e96fd4a

  Copy full SHA for e96fd4a

• Try reordering the unit tests? 😭

  KaiSernLim

  committed
  e305f09

  Copy full SHA for e305f09

• It was the `configure()` taking a long time, wasn't it? 🤪

  KaiSernLim

  committed
  6da0bcd

  Copy full SHA for 6da0bcd

• Added the finishing touches.

  KaiSernLim

  committed
  545f841

  Copy full SHA for 545f841