Try setting bootstrapToOnlineTimeoutInHours directly, instead of relying on storeResponse. 🥸

Author: KaiSernLim

clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java

@@ -668,8 +668,7 @@ public void run() {
           pushJobSetting.storeName,
           pushJobSetting.clusterName);
 
-      long bootstrapToOnlineTimeoutInHours =
-          getStoreResponse(pushJobSetting.storeName).getStore().getBootstrapToOnlineTimeoutInHours();
+      long bootstrapToOnlineTimeoutInHours = getBootstrapToOnlineTimeoutInHours();
       timeoutExecutor.schedule(() -> {
         cancel();
         throw new VeniceException(
@@ -2645,6 +2644,12 @@ public String getTopicToMonitor() {
     return getTopicToMonitor(this.pushJobSetting);
   }
 
+  // Visible for testing
+  public long getBootstrapToOnlineTimeoutInHours() {
+    // getStoreResponse() is necessary because this is called at the very start of the job
+    return getStoreResponse(pushJobSetting.storeName).getStore().getBootstrapToOnlineTimeoutInHours();
+  }
+
   private String getTopicToMonitor(PushJobSetting pushJobSetting) {
     return Version.isRealTimeTopic(pushJobSetting.topic)
         ? Version.composeKafkaTopic(pushJobSetting.storeName, pushJobSetting.version)

clients/venice-push-job/src/test/java/com/linkedin/venice/hadoop/VenicePushJobTest.java

@@ -335,11 +335,6 @@ public void testDataWriterComputeJobTimeout(Class<? extends DataWriterComputeJob
     doReturn(response).when(client).killOfflinePushJob(anyString());
 
     try (VenicePushJob pushJob = getSpyVenicePushJob(props, client)) {
-      StoreInfo storeInfo = new StoreInfo();
-      storeInfo.setBootstrapToOnlineTimeoutInHours(0);
-      PushJobSetting pushJobSetting = pushJob.getPushJobSetting();
-      pushJobSetting.storeResponse = new StoreResponse();
-      pushJobSetting.storeResponse.setStore(storeInfo);
       CountDownLatch runningJobLatch = new CountDownLatch(1);
       CountDownLatch killedJobLatch = new CountDownLatch(1);
       skipVPJValidation(pushJob);
@@ -369,6 +364,7 @@ public void testDataWriterComputeJobTimeout(Class<? extends DataWriterComputeJob
 
       try {
         doCallRealMethod().when(pushJob).runJobAndUpdateStatus();
+        doReturn(0L).when(pushJob).getBootstrapToOnlineTimeoutInHours(); // timeoutExecutor can immediately run
         DataWriterComputeJob dataWriterJob = spy(pushJob.getDataWriterComputeJob());
         pushJob.setDataWriterComputeJob(dataWriterJob);
         doNothing().when(dataWriterJob).validateJob();