-
Notifications
You must be signed in to change notification settings - Fork 98
[vpj] Push Job Timeout #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KaiSernLim
merged 20 commits into
linkedin:main
from
KaiSernLim:vpj-datawriterjob-timeout
May 22, 2025
Merged
[vpj] Push Job Timeout #1786
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8ebedc2
Removed old `bootstrapToOnlineOnlineTimeoutInHours` usage since it's …
KaiSernLim dddea75
First attempt at adding a timeout to cancel the job. 🌗
KaiSernLim 82a2c2d
Implement timeout handling for VenicePushJob and add unit test for ti…
KaiSernLim cf391b1
Two unit tests for verification. 🚏
KaiSernLim 387ff49
Fixed the unit test to actually test something meaningful. 🎤
KaiSernLim 12902db
Fixed NPE from `storeResponse` not being populated. 🦆
KaiSernLim 3d1f33d
Fixed Spotbugs warning in test. 🥱
KaiSernLim 7cc99a3
Fixed `controllerClient` NPE. 🐻❄️
KaiSernLim e02f96c
Refactored `timeoutExecutor` to be a member variable.
KaiSernLim 210c28c
Minor review changes by Nisarg. 🪡
KaiSernLim eac4a66
Try setting `bootstrapToOnlineTimeoutInHours` directly, instead of re…
KaiSernLim 5540f7f
Revert "Try setting `bootstrapToOnlineTimeoutInHours` directly, inste…
KaiSernLim 2f9f9fe
Try changing the condition in the test. 😪
KaiSernLim 07d8ab9
Only check `KILLED` status in unit test. 🤖
KaiSernLim eca6ef3
I can't tell which branches the unit test is going into in CI. 😭
KaiSernLim 74da931
Is the latch even counting down? 😭
KaiSernLim e96fd4a
Is the latch even counting down? 😭
KaiSernLim e305f09
Try reordering the unit tests? 😭
KaiSernLim 6da0bcd
It was the `configure()` taking a long time, wasn't it? 🤪
KaiSernLim 545f841
Added the finishing touches.
KaiSernLim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.