-
Notifications
You must be signed in to change notification settings - Fork 2
Jetty support: bump to 5.0.0, fix package names #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Major version numbers have been removed from package names in Gazebo Jetty, so extra cmake config files are no longer needed. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This allows vendoring from a specified vcs ref instead of the hard-coded tag. When this option is set to true, a branch, tag, or commit can be specified in the LIB_VCS_REF variable. If LIB_VCS_REF is unspecified, vendoring will use main. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
CI to build all ROS core packages above https://ci.ros2.org/job/ci_launcher/16858 Edit: The linux job failed because of an outage of archive.ubuntu.com. Rertry: |
I realized it is not possible to run the build up to The first build failed due to an issue in gz-gui, which was fixed by gazebosim/gz-gui#713. The second build passed: I did see the following warnings: CMake Warning:
Manually-specified variables were not used by the project:
BUILD_DOCS
In file included from /usr/include/pybind11/pybind11.h:16,
from /tmp/ws/build_isolated/gz_sim_vendor/gz_sim_vendor-prefix/src/gz_sim_vendor/src/SimulationRunner.cc:25:
In destructor ‘pybind11::gil_scoped_release::~gil_scoped_release()’,
inlined from ‘constexpr void std::_Optional_payload_base<_Tp>::_M_destroy() [with _Tp = pybind11::gil_scoped_release]’ at /usr/include/c++/13/optional:287:35,
inlined from ‘constexpr void std::_Optional_payload_base<_Tp>::_M_reset() [with _Tp = pybind11::gil_scoped_release]’ at /usr/include/c++/13/optional:318:14,
inlined from ‘std::_Optional_payload<_Tp, false, _Copy, _Move>::~_Optional_payload() [with _Tp = pybind11::gil_scoped_release; bool _Copy = false; bool _Move = false]’ at /usr/include/c++/13/optional:441:65,
inlined from ‘std::_Optional_base<pybind11::gil_scoped_release, false, false>::~_Optional_base()’ at /usr/include/c++/13/optional:512:12,
inlined from ‘std::optional<pybind11::gil_scoped_release>::~optional()’ at /usr/include/c++/13/optional:707:11,
inlined from ‘{anonymous}::MaybeGilScopedRelease::~MaybeGilScopedRelease()’ at /tmp/ws/build_isolated/gz_sim_vendor/gz_sim_vendor-prefix/src/gz_sim_vendor/src/SimulationRunner.cc:82:8,
inlined from ‘{anonymous}::MaybeGilScopedRelease::~MaybeGilScopedRelease()’ at /tmp/ws/build_isolated/gz_sim_vendor/gz_sim_vendor-prefix/src/gz_sim_vendor/src/SimulationRunner.cc:82:8,
inlined from ‘void gz::sim::v10::SimulationRunner::UpdateSystems()’ at /tmp/ws/build_isolated/gz_sim_vendor/gz_sim_vendor-prefix/src/gz_sim_vendor/src/SimulationRunner.cc:647:5:
/usr/include/pybind11/gil.h:171:33: warning: ‘*(pybind11::gil_scoped_release*)((char*)&release + offsetof(<unnamed>::MaybeGilScopedRelease, <unnamed>::MaybeGilScopedRelease::release.std::optional<pybind11::gil_scoped_release>::<unnamed>.std::_Optional_base<pybind11::gil_scoped_release, false, false>::<unnamed>)).pybind11::gil_scoped_release::tstate’ may be used uninitialized [-Wmaybe-uninitialized]
171 | PyEval_RestoreThread(tstate);
| ~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/tmp/ws/build_isolated/gz_sim_vendor/gz_sim_vendor-prefix/src/gz_sim_vendor/src/SimulationRunner.cc: In member function ‘void gz::sim::v10::SimulationRunner::UpdateSystems()’:
/tmp/ws/build_isolated/gz_sim_vendor/gz_sim_vendor-prefix/src/gz_sim_vendor/src/SimulationRunner.cc:644:29: note: ‘*(pybind11::gil_scoped_release*)((char*)&release + offsetof(<unnamed>::MaybeGilScopedRelease, <unnamed>::MaybeGilScopedRelease::release.std::optional<pybind11::gil_scoped_release>::<unnamed>.std::_Optional_base<pybind11::gil_scoped_release, false, false>::<unnamed>)).pybind11::gil_scoped_release::tstate’ was declared here
644 | MaybeGilScopedRelease release;
| ^~~~~~~
lto-wrapper: warning: using serial compilation of 9 LTRANS jobs
lto-wrapper: note: see the ‘-flto’ option documentation for more information
lto-wrapper: warning: using serial compilation of 2 LTRANS jobs
lto-wrapper: note: see the ‘-flto’ option documentation for more information I'll go ahead and merge all the Jetty PRs now and sort out these warnings later since they dont' seem critical. |
Part of gazebosim/gz-jetty#38.
This bumps the gz-cmake version to 5.0.0 and adjusts for the removal of major versions from cmake package names and cmake targets (see gazebo-tooling/release-tools#1244). This removes the need for the extra unversioned cmake config files, since these are now provided by the upstream package.
In order to test the vendor packages before stable releases have been made, a
VENDOR_FROM_LIB_VCS_REF
option is added. The option isOFF
by default, but when enabled allows vendoring from a branch, tag or commit specified in theLIB_VCS_REF
variable ormain
ifLIB_VCS_REF
is unspecified.