-
Notifications
You must be signed in to change notification settings - Fork 1
Add script to parse a gazebodistro file and create all vendor packages #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Write each vendor package to a subfolder of the output_dir arg named after the vendor package. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Thanks, this is a great script! I added an
and then I ran the following command to update the gz-cmake, gz-tools, gz-utils, gz-math, and sdformat vendor package pull request branches that were already open as part of gazebosim/gz-jetty#38
since I already had the vendor packages cloned at
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the script works; we should document how to use it in the README
|
||
|
||
def get_collection_local(release): | ||
with open(expanduser(f"~/ws/{release}/src/collection-{release}.yaml"), "r") as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this path is a bit hard-coded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a workaround for getting rate limited. Normally, the get_collection
function should be used to download the collection from Github. I've left this for now and made a change at the callsite to use get_collection
.
CLI11 is not yet available on ci.ros2.org, so use the vendored version --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <computersthatmove@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
This is a convenient tool for creating/updating vendor packages based on the branch names in a gazebodistro file