Skip to content

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Sep 2, 2025

This is a convenient tool for creating/updating vendor packages based on the branch names in a gazebodistro file

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters September 2, 2025 16:57
azeey and others added 3 commits September 4, 2025 15:35
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Write each vendor package to a subfolder of the
output_dir arg named after the vendor package.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link

scpeters commented Sep 4, 2025

Thanks, this is a great script! I added an --output_dir argument in c15ceb0 that will write each vendor package as a subfolder of that directory like:

<output_dir>/gz_cmake_vendor
<output_dir>/gz_utils_vendor

and then I ran the following command to update the gz-cmake, gz-tools, gz-utils, gz-math, and sdformat vendor package pull request branches that were already open as part of gazebosim/gz-jetty#38

# assuming that ~/ws/jetty/src/collection-jetty.yaml exists with the right content
python3 create_gz_vendor_pkg/gz_vendor_all_libs.py \
  jetty \
  --suffix_from_cmake \
  --overwrite_cmake_configs \
  --output_dir=$HOME/ws/gz_vendor_sdformat/src/gz_libs

since I already had the vendor packages cloned at ~/ws/gz_vendor_sdformat/src/gz_libs/. I then committed the additonal changes to these branches

Copy link

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script works; we should document how to use it in the README



def get_collection_local(release):
with open(expanduser(f"~/ws/{release}/src/collection-{release}.yaml"), "r") as f:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this path is a bit hard-coded

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a workaround for getting rate limited. Normally, the get_collection function should be used to download the collection from Github. I've left this for now and made a change at the callsite to use get_collection.

azeey and others added 2 commits September 19, 2025 19:26
CLI11 is not yet available on ci.ros2.org, so use the vendored version


---------

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Steve Peters <computersthatmove@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit 6c011aa into main Sep 20, 2025
@azeey azeey deleted the add_gz_vendor_all_libs branch September 20, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants