Jetty support: bump to 16.0.0, fix package names #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major version numbers have been removed from package names in Gazebo Jetty, so extra cmake config files are no longer needed. Also build python bindings. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This allows vendoring from a specified vcs ref instead of the hard-coded tag. When this option is set to true, a branch, tag, or commit can be specified in the LIB_VCS_REF variable. If LIB_VCS_REF is unspecified, vendoring will use main. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
16 tasks
|
Looks like we were previously skipping pybind11. Can you comment on why that's changing? |
I updated the description to say that we were previously not building python bindings since the import statements included major version numbers, but now we are able to build python bindings since the version numbers are removed, so we don't need to skip pybind11 anymore |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
See gazebo-release/gz_cmake_vendor#16 for CI tests |
azeey
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gazebosim/gz-jetty#38.
This bumps the sdformat version to 16.0.0 and adjusts for the removal of major versions from cmake package names and cmake targets (see gazebo-tooling/release-tools#1244). This removes the need for the extra unversioned cmake config files, since these are now provided by the upstream package. It also enables building of python bindings (by removing the use of the
SKIP_PYBIND11cmake variable), which is now supported since the python import statements no longer have version numbers.In order to test the vendor packages before stable releases have been made, a
VENDOR_FROM_LIB_VCS_REFoption is added. The option isOFFby default, but when enabled allows vendoring from a branch, tag or commit specified in theLIB_VCS_REFvariable ormainifLIB_VCS_REFis unspecified.