[9.0] [dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731) #238989
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
CI was triggered for this PR, but this PR targets 9.0 which should not receive a future release. CI is not supported for these branches. Please consult the release schedule, or contact The following branches are currently considered to be open:
|
1 similar comment
|
CI was triggered for this PR, but this PR targets 9.0 which should not receive a future release. CI is not supported for these branches. Please consult the release schedule, or contact The following branches are currently considered to be open:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation