[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar #238731
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out in the KQL search bar
|
/ci |
nreese
added
backport:version
💚 Build Succeeded
Metrics [docs]Async chunks
|
nreese
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Oct 14, 2025
|
Starting backport for target branches: 8.19, 9.0, 9.1, 9.2 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2025
…out in the KQL search bar (elastic#238731) Closes elastic#236288 ### Background elastic#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression elastic#236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control. ### Test instructions * install sample web logs and wait until its install - web logs is expected to be default data view * install sample flights data set * create new dashboard * add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT 10` * click into unified search query bar. Verify typeahead is populated from `flights` data view. * Add new control to dashboard. Ensure suggested data view is `Kibana Sample Data Logs` - meaning the control suggested the default data view and not the adhoc flights data view from the lens panel. (cherry picked from commit 01e67c3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2025
…tered out in the KQL search bar (#238731) (#238990) # Backport This will backport the following commits from `main` to `9.1`: - [[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)](#238731) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-14T17:50:51Z","message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.0.6","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar","number":238731,"url":"https://github.com/elastic/kibana/pull/238731","mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.0","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238731","number":238731,"mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2025
…tered out in the KQL search bar (#238731) (#238991) # Backport This will backport the following commits from `main` to `9.2`: - [[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)](#238731) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-14T17:50:51Z","message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.0.6","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar","number":238731,"url":"https://github.com/elastic/kibana/pull/238731","mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.0","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238731","number":238731,"mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2025
…ltered out in the KQL search bar (#238731) (#238988) # Backport This will backport the following commits from `main` to `8.19`: - [[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)](#238731) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-10-14T17:50:51Z","message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","backport:version","v9.2.0","v9.0.6","v9.3.0","v9.1.6","v8.19.6"],"title":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar","number":238731,"url":"https://github.com/elastic/kibana/pull/238731","mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.0","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/238731","number":238731,"mergeCommit":{"message":"[dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731)\n\nCloses https://github.com/elastic/kibana/issues/236288\n\n### Background\nhttps://github.com//pull/225705 fixed an issue where\ncontrols where getting created with adhoc data views. This fix cause\nregression #236288. Instead of\nfiltering out adhoc data views from dashboard.dataViews$, the fix should\noccur in the control group level and ignore adhoc data views when\nsuggesting the data view when creating a control.\n\n### Test instructions\n* install sample web logs and wait until its install - web logs is\nexpected to be default data view\n* install sample flights data set\n* create new dashboard\n* add ESQL panel with statement `FROM kibana_sample_data_flights | LIMIT\n10`\n* click into unified search query bar. Verify typeahead is populated\nfrom `flights` data view.\n* Add new control to dashboard. Ensure suggested data view is `Kibana\nSample Data Logs` - meaning the control suggested the default data view\nand not the adhoc flights data view from the lens panel.","sha":"01e67c3b061e8115c793569b7a8923fcecce9295"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236288
Background
#225705 fixed an issue where controls where getting created with adhoc data views. This fix cause regression #236288. Instead of filtering out adhoc data views from dashboard.dataViews$, the fix should occur in the control group level and ignore adhoc data views when suggesting the data view when creating a control.
Test instructions
FROM kibana_sample_data_flights | LIMIT 10flightsdata view.Kibana Sample Data Logs- meaning the control suggested the default data view and not the adhoc flights data view from the lens panel.