Skip to content

[9.0] [dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731) #238989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from
Open

[9.0] [dashboard] fix Adhoc dataviews from ES|QL charts are being filtered out in the KQL search bar (#238731) #238989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...m/packages/shared/presentation/presentation_publishing/interfaces/publishes_data_views.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ import { DataView } from '@kbn/data-views-plugin/common';
import { PublishingSubject } from '../publishing_subject';

/**
* This API publishes a list of data views that it uses. Note that this should not contain any
* ad-hoc data views.
* This API publishes a list of data views that it uses.
*/
export interface PublishesDataViews {
dataViews$: PublishingSubject<DataView[] | undefined>;
Expand Down
2 changes: 1 addition & 1 deletion src/platform/plugins/shared/controls/public/control_group/get_control_group_factory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export const getControlGroupEmbeddableFactory = () => {
isEditingEnabled: () => true,
openAddDataControlFlyout: (settings) => {
const parentDataViewId = apiPublishesDataViews(parentApi)
? parentApi.dataViews$.value?.[0]?.id
? parentApi.dataViews$.value?.find((dataView) => dataView.isPersisted())?.id
: undefined;
const newControlState = controlsManager.getNewControlState();

Expand Down
4 changes: 1 addition & 3 deletions src/platform/plugins/shared/dashboard/public/dashboard_api/data_views_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ export function initializeDataViewsManager(
const dataViewsSubscription = combineLatest([controlGroupDataViewsPipe, childDataViewsPipe])
.pipe(
switchMap(async ([controlGroupDataViews, childDataViews]) => {
const allDataViews = [...(controlGroupDataViews ?? []), ...childDataViews].filter(
(dataView) => dataView.isPersisted()
);
const allDataViews = [...(controlGroupDataViews ?? []), ...childDataViews];

if (allDataViews.length === 0) {
try {
Expand Down