mavlink_receiver: fix "Upgrade to MAVLink v2 ..." message spamming bug #25758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 1 before to avoid the message that comes with it being spammed.
alexcekay
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Because of the message I had added in the end here:
#25583 (comment)
Solution
Only enter the switch to MAVLink v2 case with the message if it was previously v1. Entering all the time wasn't expensive before we added the message and I kept the original design choice. But of course it makes sense to only switch to v2 (and output a message) if it was v1 before.
So now the message only appears once if MAVLink version was configured to v1 and QGC sending v2 is connected.
Changelog Entry
Test coverage
See screenshots, I ran into this using simulation (
make px4_sitl sihsim_quadx) and also verified the change to fix the problem but still switch when expected in the same environment.