-
Notifications
You must be signed in to change notification settings - Fork 14.6k
Use MAVLink v1 only as opt-in #25583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 16 byte (0 %)]
px4_fmu-v6x [Total VM Diff: 0 byte (0 %)]
Updated: 2025-10-14T05:04:20 |
The Holybro Micro OSD V2 seems to want MavLInk 1. See https://holybro.com/products/micro-osd-v2 "Download: Holybro_MicroOSD_v2.0_Manual.pdf" page 6. I can try forcing it to MavLink 2 to see if it is supported if you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am strongly in favor of this
Me too. |
I'm not against it but one way to prevent problems would be to just set |
Let's just change the default to 2 and consider dropping the autodetection code. |
I like changing the default |
c09d244
to
d8fa8d1
Compare
Feedback taken:
How about that? The option to not adapt to v2 is not great because the parameter |
81daccf
to
1fc5b5f
Compare
1fc5b5f
to
002170e
Compare
I addressed previous comments. Changed the wording to hopefully be more understandable and made it spit out a |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
No flaws found |
Solved Problem
I had heard from two completely independent real world use cases now that erroneously defaulted to MAVLink 1 for the connection between autopilot and ground station and this caused the link to get unusable. I'm not aware of any component that does not support MAVLink 2 and assume no one tests MAVLink 1.
Solution
I want to get broader feedback on who is using MAVLink 1 and if they are willing to either upgrade to a protocol version which was introduced 9 years ago (mavlink/mavlink#535) or maintain and test its support while we rather default to MAVLink 2.
Changelog Entry
Alternatives
I'm aware that reverting 1493ebf might solve issues but I really doubt this setting is useful if it doesn't get tested and there's no MAVLink 1 use case.
Test coverage
Simulation with QGC works fine. I'll invest more time into testing once this suggestion gets positive feedback.
FYI @vlad-serbanica @jeremyzff @julianoes @hamishwillee