Skip to content

Conversation

chfriedrich98
Copy link
Contributor

@chfriedrich98 chfriedrich98 commented May 28, 2025

Solved Problem

Continuation of #24836 and #24923.

This PR updates the mecanum module to the following control structure:
rover_refactor6

This is done to prepare the rover modules (and the RoverSpecificSetpoints) for access through API and is achieved through the following steps:

  1. Seperate Actuator Control: This streamlines the Input/Output flow of the rover specific uORB messages.
  2. Update Position Control: So far, in auto and manual position mode, position control directly published RoverVelocitySetpoints.
    Position control now always turns a RoverPositionSetpoint into a RoverVelocitySetpoint which further streamlines the Input/Output flow of the rover specific uORB messages.
  3. Centralize mode management, resets, checks and setpoint generation: This is now all done in RoverMecanum. Based on the control mode, it will generate RoverSetpoints and update the necessary controllers . Further, sanity checks are now only performed on parameter or control mode changes.

Tests

Tested in SITL
Hardware tests:

@chfriedrich98 chfriedrich98 self-assigned this May 28, 2025
@chfriedrich98 chfriedrich98 moved this to 🏗 In Progress in PX4 Rover May 28, 2025
@chfriedrich98 chfriedrich98 force-pushed the pr-mecanum_task_manager branch 2 times, most recently from 76d48cf to b2c62ec Compare May 28, 2025 09:13
@chfriedrich98 chfriedrich98 force-pushed the pr-mecanum_task_manager branch from b2c62ec to f2eb9c1 Compare June 10, 2025 07:35
@chfriedrich98 chfriedrich98 force-pushed the pr-mecanum_task_manager branch from f2eb9c1 to 0318a2a Compare June 10, 2025 13:09
@chfriedrich98 chfriedrich98 marked this pull request as ready for review June 10, 2025 13:10
@chfriedrich98 chfriedrich98 requested a review from sfuhrer June 10, 2025 13:10
@chfriedrich98 chfriedrich98 moved this from 🏗 In Progress to 👀 In Review in PX4 Rover Jun 10, 2025
@sfuhrer sfuhrer merged commit d348bf4 into main Jun 11, 2025
68 of 69 checks passed
@sfuhrer sfuhrer deleted the pr-mecanum_task_manager branch June 11, 2025 12:17
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in PX4 Rover Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants