Skip to content

Conversation

beniaminopozzan
Copy link
Member

Solved Problem

While performing filter tuning, QGC keeps notifying that the IMU_GYRO_* parameter requires reboot.
However, it is not nessary those parameter updates are applied immediately.

Solution

  • Set @reboot_required false on the parameters

Changelog Entry

N/A

Alternatives

N/A

Test coverage

N/A

Context

Related links, screenshot before/after, video

Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
@dakejahl
Copy link
Contributor

dakejahl commented Mar 2, 2025

The reboot required flag just indicates that the parameters won't get applied unless you reboot. But I just checked IMU_GYRO_CUTOFF and in the 3 modules that it's used in it does get updated at runtime. Can you check the other params and verify they're all being updated at runtime before removing the flag?

@sfuhrer sfuhrer requested a review from bresch March 3, 2025 09:53
@beniaminopozzan
Copy link
Member Author

Hey @dakejahl , so all parameters but IMU_GYRO_RATEMAX are only used in vehicle_angular_velocity and they are constantly checked on the run() function.

However, IMU_GYRO_RATEMAX is also used by the drivers and it does not update at runtime, apologies - fixed now in the last commit

@dakejahl dakejahl merged commit 9198125 into main Mar 3, 2025
62 checks passed
@dakejahl dakejahl deleted the imu_gyro_params_no_reset_required branch March 3, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants