Enhanced attitude control via scripting #25814
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
force-pushed
the
pr-attitude-scripting
branch
from
2bd2a7c to
c603159
Compare
timtuxworth
reviewed
Feb 26, 2024
andyp1per
force-pushed
the
pr-attitude-scripting
branch
2 times, most recently
from
38ef3e8 to
c616ec2
Compare
IamPete1
requested changes
Aug 24, 2024
Comment on lines
+932
to
+1056
| singleton AC_Fence method get_safe_alt_min float | ||
| singleton AC_Fence method get_safe_alt_max float | ||
| singleton AC_Fence method present uint8_t | ||
| singleton AC_Fence method get_enabled_fences uint8_t |
There was a problem hiding this comment.
I think the fence stuff should be a separate PR.
There was a problem hiding this comment.
Its a separate commit now - is that enough? If not I'll separate out when the stuff I'm working on that is using this is done.
rmackay9
reviewed
Aug 26, 2024
andyp1per
force-pushed
the
pr-attitude-scripting
branch
from
c616ec2 to
42d33af
Compare
andyp1per
force-pushed
the
pr-attitude-scripting
branch
2 times, most recently
from
048c580 to
faffc42
Compare
andyp1per
force-pushed
the
pr-attitude-scripting
branch
4 times, most recently
from
d573748 to
265d564
Compare
add set_target_angle_and_rate_and_throttle() for precise vehicle control
add set_target_angle_and_rate_and_throttle() for precise vehicle control
docs for set_target_velocity_NED() add set_target_angle_and_rate_and_throttle() for precise vehicle control manual binding for set_target_velocity_NED() to allow optional boolean
andyp1per
force-pushed
the
pr-attitude-scripting
branch
from
265d564 to
20b5d9c
Compare
IamPete1
reviewed
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #25698
Add support for:
set_target_velocity_NEDwith yaw controlset_target_angle_and_rate_and_throttlefor direct access to guided controllerget_safe_alt_min, get_safe_alt_max, present, get_enabled_fencesget_throttle_in