-
Notifications
You must be signed in to change notification settings - Fork 7.6k
drivers: sdhc: Add support for Apollo510 SDIO host #92455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
drivers: sdhc: Add support for Apollo510 SDIO host #92455
Conversation
Hello @fanwang-ambiq, and thank you very much for your first pull request to the Zephyr project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds Apollo510 SDIO host support by defining device tree nodes, board configuration, sample overlay, and YAML updates.
- Introduces SDIO nodes (
sdio0
,sdio1
) with power-delay settings in the SoC DTS include - Updates board DTS (
apollo510_evb.dts
) and pinctrl to configure SDIO interfaces - Provides sample overlay and Kconfig for FS sample, and marks
sdio
as a supported feature in board YAML
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
samples/subsys/fs/fs_sample/boards/apollo510_evb.overlay | Enables SDIO0 and aliases it for the FS sample |
samples/subsys/fs/fs_sample/boards/apollo510_evb.conf | Turns on MMC/SDHC and related configs for Apollo510 EVB |
dts/arm/ambiq/ambiq_apollo510.dtsi | Adds sdio0 /sdio1 nodes with timing and power-delay |
boards/ambiq/apollo510_evb/apollo510_evb.yaml | Includes sdio in supported features |
boards/ambiq/apollo510_evb/apollo510_evb.dts | Configures pinctrl, delays, and status for SDIO ports |
boards/ambiq/apollo510_evb/apollo510_evb-pinctrl.dtsi | Defines pin groups for SDIO0 and SDIO1 interfaces |
Comments suppressed due to low confidence (4)
dts/arm/ambiq/ambiq_apollo510.dtsi:588
- This
50ms
value is a magic number that impacts card power-up timing; please add a comment or reference explaining how it was derived and why it optimizes performance.
power-delay-ms = <50>;
boards/ambiq/apollo510_evb/apollo510_evb.dts:215
- The
&sdio1
node is enabled but has nommc
child for a disk device. If you intend to expose an SD card on SDIO1, add ammc
subnode (compatible = "zephyr,mmc-disk"
,disk-name
, andstatus
) similar tosdio0
.
&sdio1 {
boards/ambiq/apollo510_evb/apollo510_evb-pinctrl.dtsi:440
- [nitpick] Groups 2–5 reuse the same GPIO pins (
GPIO_P161
,GPIO_P175
) with differentambiq,sdif-cdwp
values, which may be confusing. Consider documenting the purpose of each group or refactoring duplicated settings.
group5 {
samples/subsys/fs/fs_sample/boards/apollo510_evb.conf:1
- There’s no test added to verify SDIO disk functionality with this configuration. Consider adding or enabling a CI test under
tests/drivers/mmc
or in the FS sample to catch SDIO regressions.
CONFIG_DISK_DRIVER_MMC=y
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add or reuse a section in the zephyr\samples\subsys\fs\fs_sample\sample.yaml to let CI compile the sample for our boards.
836cda8
to
8a6bcb7
Compare
8a6bcb7
to
a3af4b2
Compare
This commit adds support for ambiq SDIO host driver Signed-off-by: Fan Wang <fan.wang@ambiq.com>
a3af4b2
to
09949aa
Compare
|
@swift-tk Re-assigning to you as this is your platform (and I do not really know much about SDIO). |
This commit adds apollo510 dts, dtsi, yaml to support apollo510 SDIO host, configured sdio power delay time to enhance apollo510 SDIO performance, fs_sample worked normally, the passed log as follow picture
