drivers: sdhc: Add support for Apollo510 SDIO host #92229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessandroLuo
force-pushed
the
apollo510-sdio-merge
branch
from
9ddb318 to
8dcc1f3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
AlessandroLuo
force-pushed
the
apollo510-sdio-merge
branch
2 times, most recently
from
d0ef6c8 to
99ce267
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Ambiq Apollo510 SDIO host support by extending the SD/MMC drivers and adding board, device tree, and sample configurations for the Apollo510 evaluation board.
- Save OCR from CMD5 and mask/set OCR argument correctly in SDIO init.
- Add configurable 1/4-bit SDIO modes, MMC DDR50 timing, and dynamic timing selection.
- Update device trees, board YAML, and samples for Apollo510 EVB.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| subsys/sd/sdio.c | Save OCR value; mask OCR_ARG; conditional bus-width call |
| subsys/sd/mmc.c | Introduce MMC DDR50 logic; unified timing mode; bus-width init |
| subsys/sd/Kconfig | New config options for SDIO 1-bit and MMC bus widths |
| samples/subsys/fs/fs_sample/sample.yaml | Add build-only SDMMC test for Apollo510 EVB |
| samples/subsys/fs/fs_sample/boards/apollo510_evb.overlay | Enable sdio0 in sample overlay |
| samples/subsys/fs/fs_sample/boards/apollo510_evb.conf | Apollo510 EVB build config options |
| dts/arm/ambiq/ambiq_apollo510.dtsi | Add disabled sdio0/sdio1 nodes |
| boards/ambiq/apollo510_evb/apollo510_evb.yaml | Add sdio to supported subsystems |
| boards/ambiq/apollo510_evb/apollo510_evb.dts | Configure sdio0 pinctrl and mmc-disk status |
| boards/ambiq/apollo510_evb/apollo510_evb-pinctrl.dtsi | Define sdio0/1 pin groups |
Comments suppressed due to low confidence (1)
samples/subsys/fs/fs_sample/sample.yaml:85
- [nitpick] This sample is marked
build_only:trueand lacks runtime tests. Consider adding arun:section or actual filesystem operations to validate SDMMC functionality on Apollo510 EVB.
sample.filesystem.fat_fs.apollo510_evb_sdmmc:
github-actions
bot
added
area: File System
area: Disk Access
platform: Ambiq
github-actions
bot
requested review from
aaronyegx,
danieldegrasse,
de-nordic,
decsny,
jfischer-no,
kartben,
Laczen,
nashif and
RichardSWheatley
This commit adds support for ambiq SDIO host driver Signed-off-by: Fan Wang <fan.wang@ambiq.com>
AlessandroLuo
force-pushed
the
apollo510-sdio-merge
branch
from
99ce267 to
54c6264
Compare
|
|
Moved to #92455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for ambiq SDIO host driver