CP-49928/static-vdis: Add tests (1/3 of: prepare move to python3/)
#5740
Conversation
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
static_vdis-test_functions_before_type_fixes
branch
from
1a21de9 to
d6ac6a6
Compare
There was a problem hiding this comment.
Details:
This PR extracts the 1st commit of #5731 for a smaller/split review and merge:
Before scripts/static-vdis can be moved to the python3 tree, the pytype warnings need to be fixed.
- For this, a few functions need tiny, mostly stylistic changes to satisfy type checking warnings.
But before we can do that:
- the functions need code coverage to pass the diff-coverage check in CI.
Hence, add two simple test cases to:
- cover these functions
and to - test them to ensure that they continue to work.
PS:
By already having the approvals of @psafont and @stephenchengCloud as part of #5731, this already has two approvals:
- One by @psafont (1 of two needed member approvals) and one by @stephenchengCloud as a guest.
- I opened this just to make the remaining PR that fixes the type warnings much smaller.
Updates applied:
-
Added
mvoftest_static_vdis.pytopython3/tests/ -
Applied using pytest infrastructure to simplify the test cases a lot.
-
Rebased to the latest tip of
feature/py3with race fixes for CI and two python moves merged. -
This provides the groundwork (pre-conditions) for fixing the pytype and pyright warnings of static-vdis in CP-49928/
static-vdis: Fix pyright (3/3 of: prepare move topython3/) #5731:- After this is done, the next CP-49928/
static-vdis: Fix pyright (3/3 of: prepare move topython3/) #5731 can be reviewed, or its 2nd commit can be split from it- After this is done, the
mvofstatic-vdistopython3/should be possible to do.
- After this is done, the
- After this is done, the next CP-49928/
bernhardkaindl
changed the title
list_vdis() and fresh_name() of static-vdis .static-vdis: Add tests (1/3 of: prepare move to python3/)
bernhardkaindl
requested review from
snwoods,
gangj,
kc284,
Vincent-lau,
edwintorok,
CitrixChris,
lindig,
minglumlu,
danilo-delbusso and
contificate
Warning fix (for pyright) in scripts/static-vdis: - fresh_name is covered by github.com/xapi-project/pull/5740 Details: Always return a value in fresh_name(): - Was already so, but pyright doesn't "understand" this. - Fix the warning by de-indenting `return 0` of fresh_name() Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Summary:
list_vdis()andfresh_name()ofstatic-vdisAdding just for information: @ashwin9390, @stephenchengCloud