CP-49928/static-vdis: Fix pyright (3/3 of: prepare move to python3/)
#5731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardkaindl
force-pushed
the
static-vdis-pyright-fresh_name-not-None
branch
3 times, most recently
from
76f70d0 to
c8f054c
Compare
|
The ocaml failure is fixed with #5726 Longer term a merge from master is needed |
bernhardkaindl
force-pushed
the
static-vdis-pyright-fresh_name-not-None
branch
from
c8f054c to
e9485b4
Compare
stephenchengCloud
approved these changes
Jun 26, 2024
psafont
approved these changes
Jun 26, 2024
bernhardkaindl
force-pushed
the
static-vdis-pyright-fresh_name-not-None
branch
from
e9485b4 to
1f44f68
Compare
bernhardkaindl
commented
Jun 26, 2024
bernhardkaindl
changed the title
static-vdis: Fix warnings before attempting to move it to python3/ (1 of many)static-vdis: Fix warnings (prepare move to python3/: all 5 commits)
bernhardkaindl
changed the title
static-vdis: Fix warnings (prepare move to python3/: all 5 commits)static-vdis: Fix pyright (3/3 of: prepare move to python3/)
Warning fix (for pyright) in scripts/static-vdis: - fresh_name is covered by github.com/xapi-project/pull/5740 Details: Always return a value in fresh_name(): - Was already so, but pyright doesn't "understand" this. - Fix the warning by de-indenting `return 0` of fresh_name() Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
- all does not need to be initialized to an empty list: It isn't used before it is set by `all = listdir(...)` and not after. - Use `if i not in files:` not some clumsy method that pylint warns on. Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
static-vdis-pyright-fresh_name-not-None
branch
from
1f44f68 to
b606836
Compare
bernhardkaindl
requested review from
contificate,
freddy77,
lindig and
Vincent-lau
lindig
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static-vdis: Fixpyrightandpylintwarnings before movingstatic-vdistopython3/.For information: @ashwin9390