Skip to content

CP-49928/static-vdis: Fix pytype (2/3 of: prepare move to python3/) #5744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bernhardkaindl
Copy link
Collaborator

@bernhardkaindl bernhardkaindl commented Jun 27, 2024

Preparation step 2 (of >=3) for the move of static-vdis to python3 for passing CI checks in python3.

  • fix the pytype warnings in scripts/static-vdis

Note: The preparation step 1 (of >=3) and the 1st commit of this PR is #5740.

Suggested steps a step-by-step review of the preparation (#5731) for the move:

  1. Find a 2nd approver for 5740 and merge it (commit 1 of 5731)
  2. Find approvers for this PR and merge it (commit 2 of 5731)
  3. Find a 2nd approver for 5731 and merge it (commit 3 of it should be sufficient though).

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl changed the title CP-49928: Fix pytype warnings in scripts/static-vdis (preparation 2 of 3 for the move to py3) CP-49928/static-vdis: Fix pytype (2/3 of: prepare move to python3/) Jun 27, 2024
@psafont psafont merged commit 5b0de9a into xapi-project:feature/py3 Jul 2, 2024
14 checks passed
@bernhardkaindl bernhardkaindl deleted the static-vdis-pytype-fixes branch July 2, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants