Remove CircleCI #17891
Remove CircleCI #17891
Conversation
jkmassel
force-pushed
the
remove/circle-ci
branch
from
11e558c to
62f97e4
Compare
|
@mokagio – this should be the last piece of the puzzle – once this lands you should have all the Buildkite tooling as part of the next release! |
There was a problem hiding this comment.
Apologies @jkmassel, I just noticed I missed something when reviewing #17862.
I could be wrong, but it looks to me like there is no way currently to tell the release-builds.yml pipeline whether it should build a beta or a stable build. In practice, I'm pretty sure the only difference is in the GitHub release always being a stable one (i.e. not having the "pre-release" checkbox selected) but I think it's something we ought to address.
I know you're AFK today and this work affect me directly, so I'm going to:
- Request changes to avoid this being merged accidentally
- Open a PR against this branch to address this
Update: Also, this doesn't use a version of release toolkit that includes the buildkite_trigger_build action, yet.
| @@ -1,6 +1,6 @@ | |||
| # WordPress for iOS # | |||
|
|
|||
| [](https://circleci.com/gh/wordpress-mobile/WordPress-iOS) | |||
| [](https://buildkite.com/automattic/wordpress-ios) | |||
There was a problem hiding this comment.
We could also remove this wholesale, given GitHub reports the build status for each commit these days, something that didn't happen at the time the badges became trendy.
This will also make the addition of a parameter to differentiate between beta and stable builds cleaner.
We'll add another one next, and the line length would have gotten too long
After adding a parameter to the `release-build-wordpress.sh` call, I got a permission denied error. See https://buildkite.com/automattic/wordpress-ios/builds/4907#226a7e18-7592-4e95-9064-2829b4cb7f12/381-383 I guess if the path to a script is the only value in the `command` node, then Buildkite calls it via `sh` (or maybe `$SHELL`), otherwise it runs it as an actual command within its shell, in which case if the script is not executable, it fails.
|
Generated by 🚫 dangerJS |
…fix-beta-builds Allow for discriminating between beta and stable when building releases on Buildkite
Got a conflict in `Gemfile.lock`:
```diff
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@@ -161,12 -159,11 +161,18 @@@ GE
xcodeproj (>= 1.13.0, < 2.0.0)
xcpretty (~> 0.3.0)
xcpretty-travis-formatter (>= 0.0.3)
++<<<<<<< HEAD
+ fastlane-plugin-appcenter (1.11.0)
+ fastlane-plugin-sentry (1.8.1)
+ fastlane-plugin-wpmreleasetoolkit (3.0.0)
++=======
+ fastlane-plugin-appcenter (1.11.1)
+ fastlane-plugin-sentry (1.11.0)
+ fastlane-plugin-wpmreleasetoolkit (2.3.0)
++>>>>>>> origin/release/19.2
activesupport (~> 5)
bigdecimal (~> 1.4)
+ buildkit (~> 1.4)
chroma (= 0.2.0)
diffy (~> 3.3)
git (~> 1.3)```
```
The reason is that `release/19.2` updated Fastlane, which in turn
updated the App Center and Sentry plugins, while this branch updated the
release toolkit.
I solved the conflict by keeping both sets of updates. I then run
`bundle install` to verify the `Gemfile.lock` was functional.
|
Ouch! Auto-merge kicked in because there are no GitHub checks requirements on the release branch 🤔
|
|
It looks like Octokit exposes a way to set required checks while setting the branch protection: https://github.com/octokit/octokit.rb/blob/35d968fddf43f8cd7618e082e17e958be67964f1/spec/octokit/client/repositories_spec.rb#L225-L228 Maybe we should look into updating the release toolkit to use that? 🤔 |
Agreed!! |
|
@mokagio that's why I opened pdnsEh-7d-p2 :D Maybe it would be worth bumping the priority of that one a bit, especially given it probably won't take that much time to implement? (famous last words…) |
Removes CircleCI – replacing its last use (release builds) with API calls to Buildkite.