Skip to content

Remove CircleCI #17891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 9, 2022
Merged

Remove CircleCI #17891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
62f97e4
Remove CircleCI
jkmassel Feb 2, 2022
5e32ed7
Remove CircleCI Token from user.env-example
jkmassel Feb 4, 2022
7f5bee1
Remove deprecated lane
jkmassel Feb 4, 2022
b9ad258
Fix keychain issues
jkmassel Feb 4, 2022
3eeef7f
Point release toolkit to `trunk` to get `buildkite_trigger_build` action
mokagio Feb 4, 2022
ea7bdb7
Remove `build_and_upload_beta_release` lane, recently become unused
mokagio Feb 4, 2022
3c593f2
Remove `build_and_upload_stable_release` lane, recently become unused
mokagio Feb 4, 2022
7a94603
DRY calls to Buildkite action in `Fastfile`
mokagio Feb 4, 2022
f8087cd
Move each parameter in `release-build-wordpress.sh` to dedicate line
mokagio Feb 4, 2022
ac614d5
Allow `release-build-wordpress.sh` to specify whether to build a beta
mokagio Feb 4, 2022
a298114
Forward beta release parameter from Fastlane to Buildkite
mokagio Feb 4, 2022
ac42081
Make `release-build-*` Buildkite scripts executable
mokagio Feb 4, 2022
8db8fd3
Merge pull request #17893 from wordpress-mobile/remove/circle-ci-and-…
jkmassel Feb 8, 2022
f1728dd
Update release toolkit to version 3.0.0 to get `buildkite_trigger_build`
mokagio Feb 9, 2022
98c2bd4
Merge remote-tracking branch 'origin/release/19.2' into remove/circle-ci
mokagio Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified .buildkite/commands/release-build-jetpack.sh
100644 → 100755
View file
Open in desktop
Empty file.
Empty file modified .buildkite/commands/release-build-wordpress-internal.sh
100644 → 100755
View file
Open in desktop
Empty file.
5 changes: 4 additions & 1 deletion .buildkite/commands/release-build-wordpress.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,7 @@ echo "--- :closed_lock_with_key: Installing Secrets"
bundle exec fastlane run configure_apply

echo "--- :hammer_and_wrench: Building"
bundle exec fastlane build_and_upload_app_store_connect skip_confirm:true create_gh_release:true
bundle exec fastlane build_and_upload_app_store_connect \
skip_confirm:true \
create_gh_release:true \
beta_release:${1:-true} # use first call param, default to true for safety
2 changes: 1 addition & 1 deletion .buildkite/release-builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ common_params:
steps:

- label: "🛠 WordPress Release Build (App Store Connect)"
command: ".buildkite/commands/release-build-wordpress.sh"
command: ".buildkite/commands/release-build-wordpress.sh $BETA_RELEASE"
env: *common_env
plugins: *common_plugins
notify:
Expand Down
2 changes: 0 additions & 2 deletions .circleci/cache-version
View file
Open in desktop

This file was deleted.

298 changes: 0 additions & 298 deletions .circleci/config.yml
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ GEM
aws-eventstream (~> 1, >= 1.0.2)
babosa (1.0.4)
bigdecimal (1.4.4)
buildkit (1.4.5)
sawyer (>= 0.6)
chroma (0.2.0)
claide (1.1.0)
cocoapods (1.11.2)
Expand Down Expand Up @@ -161,9 +163,10 @@ GEM
xcpretty-travis-formatter (>= 0.0.3)
fastlane-plugin-appcenter (1.11.1)
fastlane-plugin-sentry (1.11.0)
fastlane-plugin-wpmreleasetoolkit (2.3.0)
fastlane-plugin-wpmreleasetoolkit (3.0.0)
activesupport (~> 5)
bigdecimal (~> 1.4)
buildkit (~> 1.4)
chroma (= 0.2.0)
diffy (~> 3.3)
git (~> 1.3)
Expand Down Expand Up @@ -245,7 +248,7 @@ GEM
nokogiri (1.12.5)
mini_portile2 (~> 2.6.1)
racc (~> 1.4)
octokit (4.21.0)
octokit (4.22.0)
faraday (>= 0.9)
sawyer (~> 0.8.0, >= 0.5.3)
oj (3.13.10)
Expand Down Expand Up @@ -331,7 +334,7 @@ DEPENDENCIES
fastlane (~> 2.174)
fastlane-plugin-appcenter (~> 1.8)
fastlane-plugin-sentry
fastlane-plugin-wpmreleasetoolkit (~> 2.3)
fastlane-plugin-wpmreleasetoolkit (~> 3.0)
octokit (~> 4.0)
rake
rmagick (~> 3.2.0)
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# WordPress for iOS #

[![CircleCI](https://circleci.com/gh/wordpress-mobile/WordPress-iOS.svg?style=svg)](https://circleci.com/gh/wordpress-mobile/WordPress-iOS)
[![Build status](https://badge.buildkite.com/2f3fbb17bfbb5bba508efd80f1ea8d640db5ca2465a516a457.svg)](https://buildkite.com/automattic/wordpress-ios)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also remove this wholesale, given GitHub reports the build status for each commit these days, something that didn't happen at the time the badges became trendy.

[![Reviewed by Hound](https://img.shields.io/badge/Reviewed_by-Hound-8E64B0.svg)](https://houndci.com)

## Build Instructions
Expand Down
5 changes: 1 addition & 4 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,7 @@ namespace :install do
end

def get_ci_xcode_version
ci_config = File.read(".circleci/config.yml")
specs = YAML.load(ci_config)

ci_version = specs["jobs"]["Build Tests"]["executor"]["xcode-version"]
ci_version = File.read(".xcversion")
end
end

Expand Down
Loading