Add editorialized release notes for version 19.2 #17930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also make the addition of a parameter to differentiate between beta and stable builds cleaner.
We'll add another one next, and the line length would have gotten too long
After adding a parameter to the `release-build-wordpress.sh` call, I got a permission denied error. See https://buildkite.com/automattic/wordpress-ios/builds/4907#226a7e18-7592-4e95-9064-2829b4cb7f12/381-383 I guess if the path to a script is the only value in the `command` node, then Buildkite calls it via `sh` (or maybe `$SHELL`), otherwise it runs it as an actual command within its shell, in which case if the script is not executable, it fails.
…fix-beta-builds Allow for discriminating between beta and stable when building releases on Buildkite
Got a conflict in `Gemfile.lock`:
```diff
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@@ -161,12 -159,11 +161,18 @@@ GE
xcodeproj (>= 1.13.0, < 2.0.0)
xcpretty (~> 0.3.0)
xcpretty-travis-formatter (>= 0.0.3)
++<<<<<<< HEAD
+ fastlane-plugin-appcenter (1.11.0)
+ fastlane-plugin-sentry (1.8.1)
+ fastlane-plugin-wpmreleasetoolkit (3.0.0)
++=======
+ fastlane-plugin-appcenter (1.11.1)
+ fastlane-plugin-sentry (1.11.0)
+ fastlane-plugin-wpmreleasetoolkit (2.3.0)
++>>>>>>> origin/release/19.2
activesupport (~> 5)
bigdecimal (~> 1.4)
+ buildkit (~> 1.4)
chroma (= 0.2.0)
diffy (~> 3.3)
git (~> 1.3)```
```
The reason is that `release/19.2` updated Fastlane, which in turn
updated the App Center and Sentry plugins, while this branch updated the
release toolkit.
I solved the conflict by keeping both sets of updates. I then run
`bundle install` to verify the `Gemfile.lock` was functional.
Remove CircleCI
Generated by 🚫 dangerJS |
mokagio
commented
Feb 10, 2022
ParaskP7
approved these changes
Feb 10, 2022
| * [*] Stats: fix navigation between Stats tab. [#17856] | ||
| * [**] Threaded comments: comments can now be moderated via a drop-down menu on each comment. [#17888] | ||
| * [*] Stats: Users can now add a new Insights card from the navigation bar. [#17867] | ||
| With this latest version of Jetpack, we made some design changes to help make your user experience even better. |
There was a problem hiding this comment.
Good job spotting the WordPress vs Jetpack typo from the editorial review! 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with no beta going with it so we can get these changes into
trunkand out for translation ASAP.The diff also contains the work from #17891, but that touches the CI automation only, not the app's codebase itself.