Skip to content

fix: the --devtool CLI flag not work as expected #10880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 12, 2025

Conversation

Meet-student
Copy link
Contributor

@Meet-student Meet-student commented Jul 2, 2025

Summary

fix devtool cmd line not work and default value

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jul 2, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 983bb89
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68726423c64d850008f500b1

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jul 2, 2025
Copy link

codspeed-hq bot commented Jul 2, 2025

CodSpeed Performance Report

Merging #10880 will not alter performance

Comparing Meet-student:fix/10721 (983bb89) with main (9645e50)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@Meet-student Meet-student requested a review from hardfist July 2, 2025 15:32
@Meet-student Meet-student changed the title fix: devtool cmdline not work and default value fix: devtool cmd line not work and default value Jul 3, 2025
@Meet-student
Copy link
Contributor Author

Meet-student commented Jul 4, 2025

webpack-cli development is "eval", production is false

Current devtool Value

Cmd Config Env Value
undefined undefined development cheap-module-source-map
undefined eval-cheap-module-source-map development eval-cheap-module-source-map
false eval-cheap-module-source-map development source-map
undefined undefined production source-map
undefined source-map production source-map
eval source-map production eval

@chenjiahan @hardfist @SyMind @CPunisher Help review again

@chenjiahan
Copy link
Member

@Meet-student When CI fails, you don’t need to keep rebasing the master branch. You may need to check the CI error and fix it.

@Meet-student
Copy link
Contributor Author

Meet-student commented Jul 7, 2025

@Meet-student When CI fails, you don’t need to keep rebasing the master branch. You may need to check the CI error and fix it.

@chenjiahan done

@Meet-student
Copy link
Contributor Author

Are these two CI related to this PR? @chenjiahan

@Meet-student Meet-student requested a review from chenjiahan July 10, 2025 03:22
@Meet-student
Copy link
Contributor Author

run test:ci pass

image

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@chenjiahan chenjiahan changed the title fix: devtool cmd line not work and default value fix: the --devtool CLI flag not work as expected Jul 12, 2025
@chenjiahan chenjiahan enabled auto-merge (squash) July 12, 2025 13:35
@chenjiahan chenjiahan merged commit 3a96573 into web-infra-dev:main Jul 12, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants