Merge branch 'main' into fix/10721

Author: Meet-student

.cargo/config.toml

@@ -6,7 +6,8 @@ CARGO_WORKSPACE_DIR = { value = "", relative = true }
 lint = "clippy --workspace --all-targets -- --deny warnings"
 # AKA `test-update`, handy cargo rst update without install `cargo-rst` binary
 t  = "test --no-fail-fast"
-tu = "run -p cargo-rst -- update"
+deny-ext = "run -p deny-ext"
+codegen = "run -p codegen"
 
 [target.'cfg(all())']
 rustflags = [

.github/actions/binary-limit/action.yml

@@ -3,18 +3,19 @@ name: Binary Size Limit
 description: Compare binary size with default
 
 inputs:
-  percentage-threshold:
-    description: "the"
-    default: "5"
+  size-threshold:
+    description: "the increase size limit in bytes, default is 50kb"
+    default: "51200"
     required: false
 
 runs:
   using: composite
 
   steps:
     - name: GitHub Script
-      uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea
+      uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b
       with:
         script: |
+          const limit = parseInt("${{ inputs.size-threshold }}") || 51200;
           const action = require("./.github/actions/binary-limit/binary-limit-script.js");
-          await action({github, context});
+          await action({github, context, limit});

.github/actions/binary-limit/binary-limit-script.js

@@ -2,8 +2,9 @@ const fs = require("node:fs");
 
 /**
  * @param {import("@octokit/rest")} github
+ * @param {Number} limit
  */
-module.exports = async function action({ github, context }) {
+module.exports = async function action({ github, context, limit }) {
 	const commits = await github.rest.repos.listCommits({
 		owner: context.repo.owner,
 		repo: context.repo.repo,
@@ -38,9 +39,19 @@ module.exports = async function action({ github, context }) {
 		"./crates/node_binding/rspack.linux-x64-gnu.node"
 	).size;
 
-	const comment = compareBinarySize(headSize, baseSize, baseCommit);
+	console.log(`Base commit size: ${baseSize}`);
+	console.log(`Head commit size: ${headSize}`);
+
+	const comment = compareBinarySize(headSize, baseSize, context, baseCommit);
 
 	await commentToPullRequest(github, context, comment);
+
+	const increasedSize = headSize - baseSize;
+	if (increasedSize > limit) {
+		throw new Error(
+			`Binary size increased by ${increasedSize} bytes, exceeding the limit of ${limit} bytes`
+		);
+	}
 };
 
 async function commentToPullRequest(github, context, comment) {
@@ -85,11 +96,12 @@ const SIZE_LIMIT_HEADING = "## 📦 Binary Size-limit";
 const DATA_URL_BASE =
 	"https://raw.githubusercontent.com/web-infra-dev/rspack-ecosystem-benchmark/data";
 
-function compareBinarySize(headSize, baseSize, baseCommit) {
+function compareBinarySize(headSize, baseSize, context, baseCommit) {
 	const message = baseCommit.commit.message.split("\n")[0];
 	const author = baseCommit.commit.author.name;
+	const headSha = context.payload.pull_request?.head.sha || context.sha;
 
-	const info = `> Comparing binary size with Commit: [${message} by ${author}](${baseCommit.html_url})\n\n`;
+	const info = `> Comparing [\`${headSha.slice(0, 7)}\`](${context.payload.repository.html_url}/commit/${headSha}) to  [${message} by ${author}](${baseCommit.html_url})\n\n`;
 
 	const diff = headSize - baseSize;
 	const percentage = (Math.abs(diff / baseSize) * 100).toFixed(2);

.github/workflows/ci-rust.yaml

@@ -37,6 +37,9 @@ jobs:
           save-if: ${{ github.ref_name == 'main' }}
           key: check
 
+      - name: Run Cargo codegen
+        run: cargo codegen
+
       # Compile test without debug info for reducing the CI cache size
       - name: Change profile.test
         shell: bash

.github/workflows/ci.yml

@@ -127,16 +127,26 @@ jobs:
         test-windows,
         test-mac,
         test-wasm,
-        check-changed
+        check-changed,
+        size-limit
       ]
     if: ${{ always() && !cancelled() }}
     runs-on: ubuntu-latest
     steps:
       - name: Log
         run: echo ${{ join(needs.*.result, ',') }}
       - name: Test check
-        if: ${{ needs.check-changed.outputs.code_changed == 'true' && join(needs.*.result, ',')!='success,success,success,success,success,success' }}
+        if: ${{ needs.check-changed.outputs.code_changed == 'true'
+          && github.event_name == 'pull_request'
+          && join(needs.*.result, ',')!='success,success,success,success,success,success,success' }}
         run: echo "Tess Failed" && exit 1
+
+      - name: Test check
+        if: ${{ needs.check-changed.outputs.code_changed == 'true'
+          && github.event_name != 'pull_request'
+          && join(needs.*.result, ',')!='success,success,success,success,success,success,skipped' }}
+        run: echo "Tess Failed" && exit 1
+
       - name: No check to Run test
         run: echo "Success"
 

.github/workflows/release-crates.yml

@@ -22,7 +22,9 @@ jobs:
   release_crates:
     environment: crate
     name: Release Crates
-    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    runs-on: ${{ fromJSON(vars.LINUX_SELF_HOSTED_RUNNER_LABELS ||  '"ubuntu-22.04"') }}
     needs: [rust_tests]
     if: ${{ github.event_name == 'workflow_dispatch' }}
     steps:
@@ -37,8 +39,19 @@ jobs:
           save-if: true
           key: release
 
+      - uses: cargo-bins/cargo-binstall@8aac5aa2bf0dfaa2863eccad9f43c68fe40e5ec8 # v1.14.1
+
       - name: Install cargo-workspaces
-        run: cargo install cargo-workspaces --locked
+        run: cargo binstall --no-confirm cargo-workspaces@0.4.0 --force
+
+      - name: Pnpm Setup
+        uses: ./.github/actions/pnpm/setup
+
+      - name: Pnpm Install
+        uses: ./.github/actions/pnpm/install-dependencies
+
+      - name: Run Cargo codegen
+        run: cargo codegen
 
       - name: Publish Crates
         run: |

.github/workflows/reusable-build-bench.yml

@@ -42,7 +42,7 @@ jobs:
           key: build-bench-${{ inputs.target }}
 
       - name: Install cargo-codspeed binary
-        uses: taiki-e/install-action@726a5c9e4be3a589bab5f60185f0cdde7ed4498e # v2
+        uses: taiki-e/install-action@2383334cf567d78771fc7d89b6b3802ef1412cf6 # v2
         with:
           tool: cargo-codspeed@2.10.1
 

.github/workflows/reusable-build-build.yml

@@ -61,6 +61,9 @@ jobs:
       - name: Setup Rust Target
         run: rustup target add ${{ inputs.target }}
 
+      - name: Run Cargo codegen
+        run: cargo codegen
+
       - name: Trim paths
         run: |
           echo $'\n' >> .cargo/config.toml

.github/workflows/reusable-build-codspeed.yml

@@ -30,10 +30,13 @@ jobs:
           key: build-bench-${{ inputs.target }}
 
       - name: Install cargo-codspeed binary
-        uses: taiki-e/install-action@726a5c9e4be3a589bab5f60185f0cdde7ed4498e # v2
+        uses: taiki-e/install-action@2383334cf567d78771fc7d89b6b3802ef1412cf6 # v2
         with:
           tool: cargo-codspeed@2.10.1
 
+      - name: Run Cargo codegen
+        run: cargo codegen
+
       - name: Build Benchmark
         env:
           RUSTFLAGS: "--cfg codspeed"

.github/workflows/reusable-build-test.yml

@@ -66,7 +66,7 @@ jobs:
     runs-on: ${{ fromJSON(inputs.runner) }}
     timeout-minutes: 60
     strategy:
-      fail-fast: true # for better utilize ci runners
+      fail-fast: false # wait for all test to finish for determining if it's node version based problem or general problem
       matrix:
         node: ${{ fromJSON(
           inputs.target == 'wasm32-wasip1-threads'