Skip to content

Implement timeout and scheduling logic #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 102 commits into from
Closed

Implement timeout and scheduling logic #759

wants to merge 102 commits into from

Conversation

sdvendramini
Copy link
Member

Description

WIP

Proposed Changes

Results and Evidence

Artifacts Affected

Configuration Changes

Documentation Updates

Tests Introduced

Review Checklist

  • Code changes reviewed
  • Relevant evidence provided
  • Tests cover the new functionality
  • Configuration changes documented
  • Developer documentation reflects the changes
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues
  • ...

jr0me added 30 commits April 24, 2025 15:52
@jr0me
feat: introduce evaluator classes
4896aa0 
These classes will accommodate the logic for SCA scans.
@jr0me
refactor: move implementations to source file
8c22c43
@jr0me
fix: add missing library link
9b08bd6
@jr0me
fix: clang tidy warnings
87a6756
@jr0me
tmp add ruleEvaluator class
b925bf8
@jr0me
refactor: simplify RuleEvaluator constructor and remove redundant mem…
613cd60 
…ber variables
@jr0me
feat: SCAPolicy checks type change
861b2dd
@jr0me
refactor: update SCAPolicy constructor to accept checks and modify te…
f9dc7f6 
…st cases accordingly
@jr0me
refactor: enhance SCAPolicy to support continuous running and add tim…
91c9826 
…er for policy checks
@jr0me
refactor: add CheckConditionEvaluator class to handle conditional rul…
e42a05b 
…e evaluations
@jr0me
refactor: add fromString method to CheckConditionEvaluator for condit…
028d937 
…ion type parsing
@jr0me
refactor: use CheckConditionEvaluator to simplify logic
24c8164
@jr0me
refactor: implement Stop method in SCAPolicy and update SecurityConfi…
8f7e3d1 
…gurationAssessment to stop policies
@jr0me
refactor: add ReportCheckResult method to SCAPolicy for handling chec…
8e832a5 
…k results
@jr0me
refactor: update PolicyEvaluationContext to use ConditionType and Pol…
605fd5e 
…icyVariables
@jr0me
refactor: implement RuleWithReplacedVariables method in PolicyEvaluat…
ecb4d6e 
…ionContext for variable replacement
@jr0me
refactor: add ResolvedPaths method to PolicyEvaluationContext for pat…
f126aec 
…h extraction
@jr0me
refactor: add GetPattern method to PolicyEvaluationContext for patter…
2f6bb1f 
…n extraction
@jr0me
refactor: move parsing functions to distinct file
61dadc4
@jr0me
feat: add function to parse rule type
7f4296a
@jr0me
feat: use map instead of unordered map for variables.
7bbf374 
This sorts them in place by design.
@jr0me
refactor: introduce custom comparator for PolicyVariables to sort by …
653916b 
…string length
@jr0me
feat: add requirements vector to SCAPolicy class
824a348
@jr0me
feat: implement requirement checks in SCAPolicy Run method
db5159f
@jr0me
feat: rule cannot be empty, check in constructor
ba51ece
@jr0me
refactor: simplify policy context struct
98d401d
@jr0me
refactor: split sca_policy.hpp into header and src
caa7a90
@jr0me
refactor: split sca_policy_check.hpp into header and src
fed9872
@jr0me
fix: add sca_utils.cpp to SCA target
7539af0
@jr0me
refactor: move CheckConditionEvaluator to different file
1c857f2
jr0me added 13 commits April 25, 2025 20:47
@jr0me
fix: declare PolicyEvaluationContext as const in CreateEvaluator
d44ff78
@jr0me
fix: remove redundant test for missing value pattern in RegistryRuleE…
9f36dc5 
…valuatorTest
@jr0me
fix: correct conditional logic in RegistryRuleEvaluator::Evaluate
e86bb19
@jr0me
fix: remove commented-out test for GetPolicies in ScaPolicyLoaderTest
93ae704
@jr0me
fix: rename Exec to PipeOpen for clarity in cmdHelper
4781264
@jr0me
feat: add Exec function to cmdHelper for executing commands and captu…
74f541a 
…ring output
@jr0me
feat: update Exec function to return ExecResult containing StdOut, St…
1aeecfc 
…dErr, and ExitCode
@jr0me
fix: remove unnecessary environment variable passing in Exec function
95dd7ab 
Failed to compile on windows
@jr0me
fix: initialize members in PolicyEvaluationContext for clarity
9f6d70d
@jr0me
fix: change result variable to const for better clarity in SCAPolicy:…
5f6a9d0 
…:Run
@jr0me
fix: enhance file existence checks to include regular file validation…
3163c15 
… in FileRuleEvaluator
@jr0me
fix: various small changes
eeb37a0
@jr0me
fix: improve error handling in Exec function and enhance test cases f…
63d72ca 
…or command execution
@jr0me jr0me force-pushed the enhancement/687-sca-implement-execution-logic branch from 48a7e80 to 63d72ca Compare April 29, 2025 12:42
@sdvendramini sdvendramini force-pushed the 689-sca-implement-timeout-and-scheduling-logic branch from a6a56d3 to 7889d6f Compare April 29, 2025 12:46
@sdvendramini
fix: Change Exec implementation
7fa7221 
Replaced std::views-based tokenization with std::istringstream.
Refactored GetStreamOutput to accept std::istream directly,
eliminating the need to manage boost::process::pipe.
@sdvendramini
feat: Add logic to implement timeout and scheduling
988fc37 
The m_scanOnStart and m_scanInterval SCA class members are propagated to
determine whether a scan should run at startup and to control the
interval between scans.
@sdvendramini sdvendramini force-pushed the 689-sca-implement-timeout-and-scheduling-logic branch from 7889d6f to 988fc37 Compare April 29, 2025 12:52
@jr0me jr0me force-pushed the enhancement/687-sca-implement-execution-logic branch 5 times, most recently from 7545539 to 4b4fd98 Compare April 29, 2025 20:03
@TomasTurina TomasTurina linked an issue Apr 29, 2025 that may be closed by this pull request
SCA: Implement Timeout and Scheduling Logic #689
Closed
3 tasks
@jr0me jr0me force-pushed the enhancement/687-sca-implement-execution-logic branch 4 times, most recently from dc121c5 to 7ad508c Compare April 30, 2025 01:31
@sdvendramini sdvendramini deleted the 689-sca-implement-timeout-and-scheduling-logic branch May 5, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SCA: Implement Timeout and Scheduling Logic
3 participants
@sdvendramini @jr0me @TomasTurina