fix: improve error handling in Exec function and enhance test cases for command execution

Author: jr0me

src/common/cmdHelper/src/cmdHelper.cpp

@@ -9,6 +9,7 @@
 #include <memory>
 #include <ranges>
 #include <sstream>
+#include <stdexcept>
 #include <string>
 #include <vector>
 
@@ -91,13 +92,11 @@ namespace Utils
 
             return {.StdOut = output, .StdErr = error, .ExitCode = process.exit_code()};
         }
-        // NOLINTBEGIN(bugprone-empty-catch)
-        catch (const std::exception&)
+        catch (const std::exception& e)
         {
-            // log? throw?
+            return {.StdOut = "", .StdErr = e.what(), .ExitCode = 1};
         }
-        // NOLINTEND(bugprone-empty-catch)
 
-        return {};
+        return {.StdOut = "", .StdErr = "", .ExitCode = 1};
     }
 } // namespace Utils

src/common/cmdHelper/tests/cmdHelper_test.cpp

@@ -1,20 +1,52 @@
 #include "cmdHelper_test.hpp"
 #include "cmdHelper.hpp"
 
-void CmdUtilsTest::SetUp() {};
-
-void CmdUtilsTest::TearDown() {};
+#include <string>
 
 #ifdef WIN32
-TEST_F(CmdUtilsTest, CmdVersion)
+const std::string TEST_CMD = "ver";
+#else
+const std::string TEST_CMD = "uname";
+#endif
+
+TEST_F(CmdUtilsTest, PipeOpenCmd)
 {
-    const auto result {Utils::PipeOpen("ver")};
+    const auto result {Utils::PipeOpen(TEST_CMD)};
     EXPECT_FALSE(result.empty());
 }
-#else
-TEST_F(CmdUtilsTest, CmdUname)
+
+TEST_F(CmdUtilsTest, ExecCmd)
 {
-    const auto result {Utils::PipeOpen("uname")};
-    EXPECT_FALSE(result.empty());
+    const auto result {Utils::Exec(TEST_CMD)};
+    EXPECT_FALSE(result.StdOut.empty());
+    EXPECT_TRUE(result.StdErr.empty());
+    EXPECT_EQ(result.ExitCode, 0);
+}
+
+TEST_F(CmdUtilsTest, ExecInvalidCmd)
+{
+    const auto result {Utils::Exec("invalid_command")};
+    EXPECT_TRUE(result.StdOut.empty());
+    EXPECT_FALSE(result.StdErr.empty());
+    EXPECT_NE(result.ExitCode, 0);
+}
+
+TEST_F(CmdUtilsTest, PipeOpenInvalidCmd)
+{
+    const auto result {Utils::PipeOpen("invalid_command")};
+    EXPECT_TRUE(result.empty());
+}
+
+TEST_F(CmdUtilsTest, ExecEmptyCmd)
+{
+    const auto result {Utils::Exec("")};
+    EXPECT_TRUE(result.StdOut.empty());
+    EXPECT_FALSE(result.StdErr.empty());
+    EXPECT_NE(result.ExitCode, 0);
+}
+
+TEST_F(CmdUtilsTest, PipeOpenEmptyCmd)
+{
+    const auto result {Utils::PipeOpen("")};
+    EXPECT_TRUE(result.empty());
 }
-#endif

src/common/cmdHelper/tests/cmdHelper_test.hpp

@@ -7,7 +7,4 @@ class CmdUtilsTest : public ::testing::Test
 protected:
     CmdUtilsTest() = default;
     virtual ~CmdUtilsTest() = default;
-
-    void SetUp() override;
-    void TearDown() override;
 };