refactor: move YAML load function to policy parser

Author: jr0me

src/modules/sca/src/sca_policy_loader.cpp

@@ -5,8 +5,6 @@
 #include <logger.hpp>
 #include <sca_policy_parser.hpp>
 
-#include <yaml-cpp/yaml.h>
-
 #include <algorithm>
 
 SCAPolicyLoader::SCAPolicyLoader(std::shared_ptr<IFileSystemWrapper> fileSystemWrapper,
@@ -65,14 +63,9 @@ std::vector<SCAPolicy> SCAPolicyLoader::GetPolicies(const CreateEventsFunc& crea
             {
                 LogDebug("Loading policy from {}", path.string());
 
-                auto loadFunc = [](const std::filesystem::path& filename) -> YAML::Node
-                {
-                    return YAML::LoadFile(filename.string());
-                };
+                const PolicyParser parser(path);
 
-                const PolicyParser parser(path, loadFunc);
-                auto policy = parser.ParsePolicy(policiesAndChecks);
-                if (policy)
+                if (auto policy = parser.ParsePolicy(policiesAndChecks); policy)
                 {
                     policies.emplace_back(std::move(policy.value()));
                 }

src/modules/sca/src/sca_policy_parser.cpp

@@ -71,15 +71,16 @@ namespace
     }
 } // namespace
 
-PolicyParser::PolicyParser(const std::filesystem::path& filename, const LoadFileFunc& loadFile)
+// NOLINTNEXTLINE(performance-unnecessary-value-param)
+PolicyParser::PolicyParser(const std::filesystem::path& filename, LoadFileFunc loadFileFunc)
 {
     try
     {
         if (!isValidYamlFile(filename))
         {
             throw std::runtime_error("The file does not contain a valid YAML structure.");
         }
-        m_node = loadFile(filename);
+        m_node = loadFileFunc ? loadFileFunc(filename) : YAML::LoadFile(filename.string());
         auto variables = m_node["variables"];
         if (variables)
         {

src/modules/sca/src/sca_policy_parser.hpp

@@ -37,8 +37,8 @@ class PolicyParser
 public:
     /// @brief Constructs a PolicyParser and loads the YAML file.
     /// @param filename Path to the YAML policy file.
-    /// @param loadFile Function to load the YAML file.
-    explicit PolicyParser(const std::filesystem::path& filename, const LoadFileFunc& loadFile);
+    /// @param loadFileFunc Function to load the YAML file.
+    explicit PolicyParser(const std::filesystem::path& filename, LoadFileFunc loadFileFunc = {});
 
     /// @brief Checks if the specified YAML file is valid.
     ///