Skip to content

[Misc] Clean up Aimv2 config registration in Ovis config #20921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Jul 14, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

  • On Transformers main branch, AimV2 has been supported with model conversion, so we need to remove the original AIMv2Config registration in Ovis config porting to avoid duplicate model name:
ValueError: 'aimv2' is already used by a Transformers config, pick another name.

Test Plan

uv pip install git+https://github.com/huggingface/transformers
python examples/offline_inference/vision_language.py -m ovis

Test Result

  • Example should still work after installing transformers main branch

(Optional) Documentation Update

Isotr0py added 3 commits July 10, 2025 17:55
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py requested a review from DarkLight1337 July 14, 2025 11:55
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a configuration conflict with the aimv2 model, which is now natively supported in the transformers library's main branch. It cleans up the Ovis configuration by removing a redundant aimv2 registration and adjusts the model configuration loading logic to correctly instantiate AIMv2Config for aimv2 models, thereby preventing duplicate name errors and ensuring proper integration with the upstream transformers library.

Highlights

  • Configuration Conflict Resolution: Removed the explicit AutoConfig.register("aimv2", AIMv2Config) call in vllm/transformers_utils/configs/ovis.py. This change directly addresses a ValueError that would occur due to aimv2 being pre-registered in the upstream transformers library, ensuring compatibility when using the transformers main branch.
  • Conditional AIMv2Config Instantiation: Modified the OvisConfig's __init__ method to specifically handle aimv2 backbone configurations. Instead of relying on AutoConfig.for_model (which would now pick up the upstream transformers library's aimv2 config), AIMv2Config is now directly instantiated for aimv2 models, while other model types continue to use AutoConfig.for_model for dynamic loading.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the original AIMv2Config registration in Ovis config, resolving a duplicate model name issue. I've suggested a minor improvement for code consistency.

Comment on lines +106 to +110
if model_type != "aimv2":
backbone_config.pop('model_type')
backbone_config = AutoConfig.for_model(model_type, **backbone_config)
else:
backbone_config = AIMv2Config(**backbone_config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider popping model_type from backbone_config before the conditional check for consistency. This ensures backbone_config is handled the same way in both branches and avoids passing unexpected keys to constructors.

Suggested change
if model_type != "aimv2":
backbone_config.pop('model_type')
backbone_config = AutoConfig.for_model(model_type, **backbone_config)
else:
backbone_config = AIMv2Config(**backbone_config)
model_type = backbone_config.pop('model_type')
if model_type != "aimv2":
backbone_config = AutoConfig.for_model(model_type, **backbone_config)
else:
backbone_config = AIMv2Config(**backbone_config)

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 14, 2025 12:33
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 14, 2025
@DarkLight1337 DarkLight1337 merged commit 3fc9644 into vllm-project:main Jul 14, 2025
69 of 71 checks passed
@Isotr0py Isotr0py deleted the cleanup-ovis-config branch July 14, 2025 15:50
py-andy-c pushed a commit to py-andy-c/vllm that referenced this pull request Jul 14, 2025
py-andy-c pushed a commit to py-andy-c/vllm that referenced this pull request Jul 14, 2025
patrickvonplaten pushed a commit to patrickvonplaten/vllm that referenced this pull request Jul 15, 2025
…t#20921)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants