Skip to content

[Misc] Clean up Aimv2 config registration in Ovis config #20921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

[Misc] Clean up Aimv2 config registration in Ovis config #20921

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0748e27
remove aimv2 config registration
Isotr0py Jul 10, 2025
41f0285
fix
Isotr0py Jul 13, 2025
6d81d14
Merge branch 'vllm-project:main' into cleanup-ovis-config
Isotr0py Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions vllm/transformers_utils/configs/ovis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ def __init__(
IMAGE_ATOM_ID = -300
IMAGE_INDICATOR_IDS = [-301, -302, -303, -304, -305]

AutoConfig.register("aimv2", AIMv2Config)


# ----------------------------------------------------------------------
# Visual Tokenizer Configuration
Expand Down Expand Up @@ -105,9 +103,11 @@ def __init__(self,
f"expect `backbone_config` to be instance of PretrainedConfig or dict, but got {type(backbone_config)} type"
if not isinstance(backbone_config, PretrainedConfig):
model_type = backbone_config['model_type']
backbone_config.pop('model_type')
backbone_config = AutoConfig.for_model(model_type,
**backbone_config)
if model_type != "aimv2":
backbone_config.pop('model_type')
backbone_config = AutoConfig.for_model(model_type, **backbone_config)
else:
backbone_config = AIMv2Config(**backbone_config)
Comment on lines +106 to +110
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider popping model_type from backbone_config before the conditional check for consistency. This ensures backbone_config is handled the same way in both branches and avoids passing unexpected keys to constructors.

Suggested change
if model_type != "aimv2":
backbone_config.pop('model_type')
backbone_config = AutoConfig.for_model(model_type, **backbone_config)
else:
backbone_config = AIMv2Config(**backbone_config)
model_type = backbone_config.pop('model_type')
if model_type != "aimv2":
backbone_config = AutoConfig.for_model(model_type, **backbone_config)
else:
backbone_config = AIMv2Config(**backbone_config)

self.backbone_config = backbone_config
self.hidden_stride = hidden_stride

Expand Down