Skip to content

[CI/Build] Add Transformers nightly tests in CI #20924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Jul 14, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Isotr0py, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new continuous integration (CI) job designed to proactively test the project's compatibility with the latest development version of the Hugging Face Transformers library. This aims to identify potential breaking changes or regressions early, ensuring smoother integration and stability by catching issues before they impact stable releases.

Highlights

  • New CI Pipeline Step: A new optional step, "Transformers Nightly Models Test", has been added to the .buildkite/test-pipeline.yaml configuration.
  • Nightly Transformers Integration: This new step installs the most recent main branch version of the Hugging Face Transformers library directly from its GitHub repository.
  • Targeted Multimodal Testing: The CI job executes specific pytest suites covering multimodal model processing and mapping, along with several offline_inference examples (chat, audio-language with Whisper, and vision-language with Qwen2-5-VL).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the ci/build label Jul 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds a nightly CI job for Transformers. I've suggested making test parameters explicit and optimizing the test runner's output for CI environments to improve robustness and maintainability.

Comment on lines 638 to 639
- pytest -s -v tests/models/multimodal/processing/
- pytest -s -v tests/models/multimodal/test_mapping.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The -s flag in pytest disables output capturing, which can lead to excessively verbose CI logs. Consider removing it to keep logs clean and focused on failures.

- pytest -v tests/models/multimodal/processing/
- pytest -v tests/models/multimodal/test_mapping.py

- pip install --upgrade git+https://github.com/huggingface/transformers
- pytest -s -v tests/models/multimodal/processing/
- pytest -s -v tests/models/multimodal/test_mapping.py
- python3 examples/offline_inference/basic/chat.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Specify the model explicitly in the chat.py command to avoid unexpected behavior due to default value changes in the script.

- python3 examples/offline_inference/basic/chat.py --model meta-llama/Llama-3.2-1B-Instruct

Signed-off-by: Isotr0py <2037008807@qq.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 14, 2025 12:59
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 14, 2025
@DarkLight1337 DarkLight1337 merged commit 6d0cf23 into vllm-project:main Jul 14, 2025
107 checks passed
py-andy-c pushed a commit to py-andy-c/vllm that referenced this pull request Jul 14, 2025
py-andy-c pushed a commit to py-andy-c/vllm that referenced this pull request Jul 14, 2025
@Isotr0py Isotr0py deleted the transformers-nightly-ci branch July 15, 2025 00:13
patrickvonplaten pushed a commit to patrickvonplaten/vllm that referenced this pull request Jul 15, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants