Skip to content

Barycentric Evaluation Bench #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: gali/parallel_barycentric
Choose a base branch
from

Conversation

Gali-StarkWare
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Gali-StarkWare commented Apr 29, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (57745f8) to head (dfdc7c2).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           gali/parallel_barycentric    #1073   +/-   ##
==========================================================
  Coverage                      92.80%   92.80%           
==========================================================
  Files                            106      106           
  Lines                          14625    14625           
  Branches                       14625    14625           
==========================================================
  Hits                           13572    13572           
  Misses                           972      972           
  Partials                          81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gali-StarkWare Gali-StarkWare force-pushed the gali/parallel_barycentric branch 2 times, most recently from 1ff75ed to 8daa3b4 Compare April 29, 2025 14:31
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: dfdc7c2 Previous: 8b5436d Ratio
iffts/simd ifft/28 1274940885 ns/iter (± 8757912) 586165718 ns/iter (± 12065155) 2.18

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants